This repository was archived by the owner on Nov 6, 2020. It is now read-only.
Fix nonce reservation #7025
Merged
Fix nonce reservation #7025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomusdrw
added
A0-pleasereview 🤓
|
Does this require a patch? |
|
#6834 wasn't backported, so no. |
rphmeier
reviewed
Nov 13, 2017
rpc/src/v1/helpers/nonce.rs
Outdated
| /// The reserved nonce cannot be smaller than the minimal nonce. | ||
| pub fn reserve(&mut self, sender: Address, minimal: U256) -> Reserved { | ||
| if self.nonces.len() + 1 > Self::CLEAN_AT { | ||
| let to_remove = self.nonces.iter().filter(|&(_, v)| v.is_empty()).map(|(k, _)| *k).collect::<Vec<_>>(); |
rphmeier
added
A8-looksgood 🦄
5chdn
pushed a commit
that referenced
this pull request
Jan 9, 2018
* Reserve nonces for signing (#6834) * Nonce future - reserve and dispatch * Single thread nonce tests * Track status of reserved nonces. * Initialization of nonce reservations. * Prospective Signer * Fix cli tests. * Merge pull request #7025 from paritytech/fix-nonce-reservation Fix nonce reservation * Fix build.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kudos to @ngotchac