This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Fixed build warnings #6664
Merged
Fixed build warnings #6664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arkpar
added
A2-insubstantial 👶
tomusdrw
reviewed
Oct 6, 2017
dapps/js-glue/src/codegen.rs
Outdated
| @@ -102,7 +102,7 @@ fn implement_webapp(cx: &ExtCtxt, builder: &aster::AstBuilder, item: &Item, push | |||
| let files_impl = quote_item!(cx, | |||
| impl $type_name { | |||
| fn files() -> ::std::collections::HashMap<&'static str, File> { | |||
| let mut files = ::std::collections::HashMap::new(); | |||
There was a problem hiding this comment.
That won't work if $statements are not empty. Actually it shouldn't be printed while compiling Parity at all (since we always have some files there). Maybe better to supress the warning?
arkpar
added
A0-pleasereview 🤓
rphmeier
reviewed
Oct 7, 2017
dapps/js-glue/src/codegen.rs
Outdated
| @@ -101,6 +101,7 @@ fn implement_webapp(cx: &ExtCtxt, builder: &aster::AstBuilder, item: &Item, push | |||
|
|
|||
| let files_impl = quote_item!(cx, | |||
| impl $type_name { | |||
| #[warn(unused_mut)] | |||
There was a problem hiding this comment.
ishould it be #[allow(unused_mut)]?
There was a problem hiding this comment.
Weirdly enough it did not produce any warnings when building like this.
|
doesn't build |
5chdn
added
the
A4-awaitingci 🤖
|
CI:
@paritytech/ci ^ |
arkpar
removed
the
A4-awaitingci 🤖
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.