Skip to content
This repository was archived by the owner on Nov 6, 2020. It is now read-only.

light client fixes #6148

Merged
merged 3 commits into from
Jul 26, 2017
Merged

light client fixes #6148

merged 3 commits into from
Jul 26, 2017

Conversation

rphmeier
Copy link
Contributor

@rphmeier rphmeier commented Jul 25, 2017 •
edited
Loading

  1. only make one request from a peer per each light sync, allowing other threads to get a turn with access to the handlers.
  2. make sure genesis header is available by hash
  3. fix memory-lru-cache
  4. clear unfulfilled requests from pending requests set in light_sync on peer disconnect.

@rphmeier rphmeier added A0-pleasereview 🤓 Pull request needs code review. B0-patch M4-core ⛓ Core client code / Rust. labels Jul 25, 2017
@rphmeier rphmeier requested a review from arkpar July 25, 2017 15:21
@arkpar arkpar added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Jul 25, 2017
@rphmeier rphmeier added A3-inprogress ⏳ Pull request is in progress. No review needed at this stage. and removed A8-looksgood 🦄 Pull request is reviewed well. labels Jul 25, 2017
@rphmeier rphmeier added A0-pleasereview 🤓 Pull request needs code review. and removed A3-inprogress ⏳ Pull request is in progress. No review needed at this stage. labels Jul 26, 2017
@arkpar arkpar added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Jul 26, 2017
@arkpar arkpar merged commit 7d348e2 into master Jul 26, 2017
@arkpar arkpar deleted the light-fixes branch July 26, 2017 13:48
arkpar pushed a commit that referenced this pull request Jul 26, 2017
@rphmeier @arkpar
light client fixes (#6148)
a1abcbc 
* light client fixes

* fix memory-lru-cache

* clear pending reqs on disconnect
arkpar added a commit that referenced this pull request Jul 26, 2017
@arkpar
light client fixes (#6148) (#6151)
a554b81 
* light client fixes

* fix memory-lru-cache

* clear pending reqs on disconnect
@arkpar arkpar mentioned this pull request Jul 26, 2017
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@arkpar arkpar Awaiting requested review from arkpar

Assignees
No one assigned
Labels
A8-looksgood 🦄 Pull request is reviewed well. M4-core ⛓ Core client code / Rust.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rphmeier @arkpar