This repository was archived by the owner on Nov 6, 2020. It is now read-only.
New contract PoA sync fixes #5991
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keorn
added
A0-pleasereview 🤓
rphmeier
added
the
A4-awaitingci 🤖
keorn
removed
the
A4-awaitingci 🤖
keorn
changed the title
|
@gavofyork I'm probably not the best person to review this impartially as Peter and I made these fixes together |
arkpar
reviewed
Jul 12, 2017
| @@ -107,14 +107,14 @@ impl ValidatorSet for ValidatorContract { | |||
| fn report_malicious(&self, address: &Address, _set_block: BlockNumber, block: BlockNumber, proof: Bytes) { | |||
| match self.provider.report_malicious(&*self.transact(), *address, block.into(), proof).wait() { | |||
| Ok(_) => warn!(target: "engine", "Reported malicious validator {}", address), | |||
| Err(s) => warn!(target: "engine", "Validator {} could not be reported {}", address, s), | |||
| Err(_) => {} // warn!(target: "engine", "Validator {} could not be reported {}", address, s), | |||
There was a problem hiding this comment.
Reason for warning removal?
There was a problem hiding this comment.
good catch. it was removed before because the checks weren't in place and it made testing very spammy
arkpar
added
A5-grumble 🔥
|
@rphmeier doesn't build |
rphmeier
force-pushed
the
engine-signer-option
branch
from
ec4bf60 to
ad7507c
Compare
rphmeier
added
A3-inprogress ⏳
|
Added a few more commits to address two issues:
I would suggest keeping the additional flush for now since it's very rare, but then we can adjust |
rphmeier
added
A0-pleasereview 🤓
arkpar
added
A8-looksgood 🦄
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generate proof on uncommitted state and dont report skipped proposer if not signer.
Also prevents re-sealing on same step when validator set changes.