This repository was archived by the owner on Nov 6, 2020. It is now read-only.
Use randomized subscription ids for PubSub #5756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomusdrw
added
A0-pleasereview 🤓
rphmeier
reviewed
Jun 5, 2017
| pub struct Subscribers<T> { | ||
| next_id: u64, | ||
| subscriptions: HashMap<u64, T>, | ||
| rand: StdRng, |
There was a problem hiding this comment.
why use random IDs? is it a reason that's defeated by not using cryptographic-strength randomness?
There was a problem hiding this comment.
When you run public node it would be possible to cancel other peoples subscriptions. We could instead have an id per session, but I think it would be a bit more complicated.
There was a problem hiding this comment.
i see, but you could still guess and get lucky and cancel others'?
There was a problem hiding this comment.
Yes, you could even try to fire milions of requests and cancel all of them. But that should be that should be handled by some rate limiting (that is needed anyway).
debris
reviewed
Jun 6, 2017
rpc/src/v1/helpers/subscribers.rs
Outdated
| Err(_) => { | ||
| self.next_id -= 1; | ||
| }, | ||
| Err(_) => {}, |
NikVolf
added
A8-looksgood 🦄
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.