Skip to content
This repository was archived by the owner on Nov 6, 2020. It is now read-only.

Fix eth_sign signature encoding. #5597

Merged
merged 2 commits into from
May 11, 2017
Merged

Fix eth_sign signature encoding. #5597

merged 2 commits into from
May 11, 2017

Conversation

tomusdrw
Copy link
Collaborator

Closes #5490

@tomusdrw tomusdrw requested a review from gavofyork May 11, 2017 11:39
@tomusdrw tomusdrw added A0-pleasereview 🤓 Pull request needs code review. M6-rpcapi 📣 RPC API. labels May 11, 2017
@rphmeier rphmeier added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels May 11, 2017
@rphmeier
Copy link
Contributor

rphmeier commented May 11, 2017 •
edited
Loading

awesome, this has been long-needed :)
That said, I don't think this closes #5490 because there's still the prepended string causing confusion.

@debris
Copy link
Collaborator

debris commented May 11, 2017

lgtm!

@tomusdrw
Copy link
Collaborator Author

There is a separate issue for that #5431 I think it should be an EIP/interfaces issues instead to decide together with other client implementations. Now at least we conformc to the JSONRPC spec on ethereum/wiki and we're also geth-compatible.

@rphmeier rphmeier merged commit 83325b5 into master May 11, 2017
@rphmeier rphmeier deleted the ethsign branch May 11, 2017 14:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gavofyork gavofyork Awaiting requested review from gavofyork

Assignees
No one assigned
Labels
A8-looksgood 🦄 Pull request is reviewed well. M6-rpcapi 📣 RPC API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tomusdrw @rphmeier @debris