Skip to content
This repository was archived by the owner on Nov 6, 2020. It is now read-only.

add snap to CI #5519

Merged
merged 9 commits into from
May 3, 2017
Merged

add snap to CI #5519

merged 9 commits into from
May 3, 2017

Conversation

General-Beck
Copy link
Contributor

initial build snap package for parity

initial build snap package for parity
@General-Beck General-Beck self-assigned this Apr 27, 2017
.gitlab-ci.yml Outdated
- snap
script:
#- git clone https://github.com/paritytech/parity
- git submodule update --init --recursive
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be removed

.gitlab-ci.yml Outdated
- git submodule update --init --recursive
- cd scripts
- snapcraft
- sudo snap install *.snap --dangerous
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is the --dangerous flag used for?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rphmeier We will not use this flag, it is only for installation

Copy link
Contributor Author

@General-Beck General-Beck Apr 28, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need for test snap package https://gitlab.ethcore.io/parity/parity/builds/53332/artifacts/download
unzip and install
sudo snap install *.snap --dangerous
parity

@rphmeier rphmeier added A8-looksgood 🦄 Pull request is reviewed well. M1-ci 🙉 Continuous integration. labels May 2, 2017
.gitlab-ci.yml Outdated
@@ -60,6 +60,23 @@ linux-stable:
- target/release/ethstore
- target/release/ethkey
name: "stable-x86_64-unknown-linux-gnu_parity"
linux-snap:
stage: build
image: ethcore/snapcraft:latest
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ethcore should be migrated to paritytech at some point

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

switch to hub.docker.com/r/parity
@rphmeier rphmeier added A0-pleasereview 🤓 Pull request needs code review. and removed A8-looksgood 🦄 Pull request is reviewed well. labels May 2, 2017
build snap beta
@General-Beck General-Beck merged commit 7fd2051 into master May 3, 2017
@General-Beck General-Beck deleted the snap branch May 3, 2017 17:13
@come-maiz
Copy link

@General-Beck you are using gitlab? That's very nice!

I think you could configure this also to automate the deployment like we do in travis. You would have to encrypt the credentials [1], and then do something like this: https://github.com/elopio/ipfs-snap/blob/master/.travis.yml#L10

I haven't experimented with gitlab ci for this yet, so I'd love to help.

And there's also launchpad as an alternative, which we are currently migrating to a nicer UI in build.snapcraft.io: https://snapcraft.io/docs/build-snaps/ci-integration#using-launchpad

[1] https://docs.gitlab.com/ce/ci/variables/#secret-variables

@General-Beck
Copy link
Contributor Author

@ElOpio Thanks, I'll try

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A0-pleasereview 🤓 Pull request needs code review. M1-ci 🙉 Continuous integration.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants