Skip to content
This repository was archived by the owner on Nov 6, 2020. It is now read-only.

Update links to etherscan.io #5455

Merged
merged 1 commit into from
Apr 20, 2017
Merged

Update links to etherscan.io #5455

merged 1 commit into from
Apr 20, 2017

Conversation

dstarcev
Copy link
Contributor

  • Update links to etherscan.io to reflect recent changes (e.g. separate domain for ropsten)
  • Remove duplicated code
  • Add some tests

@parity-cla-bot
Copy link

It looks like @dstarcev hasn'signed our Contributor License Agreement, yet.

The purpose of a CLA is to ensure that the guardian of a project's outputs has the necessary ownership or grants of rights over all contributions to allow them to distribute under the chosen licence.
Wikipedia

You can read and sign our full Contributor License Agreement at the following URL: https://cla.parity.io

Once you've signed, plesae reply to this thread with [clabot:check] to prove it.

Many thanks,

Parity Technologies CLA Bot

@tomusdrw tomusdrw added A4-clasignoffneeded 📛 Pull request requires author to sign off on CLA before review/merge can begin. M7-ui labels Apr 14, 2017
This was referenced Apr 14, 2017
Closed
Closed
5chdn
5chdn reviewed Apr 18, 2017
View reviewed changes
js/src/3rdparty/etherscan/links.js Outdated
export const url = (isTestnet = false, netVersion = '0') => {
let prefix = '';
export const url = (isTestnet = false, netVersion = '0', defaultPrefix = '') => {
let prefix = defaultPrefix;

switch (netVersion) {
case '2':
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should remove '2' completely from this list, I don't know of any working morden explorer and etherscan recently told me they do not plan to maintain one.

@dstarcev
Copy link
Contributor Author

I have removed morden and added the recently born rinkeby. Parity doesn't support clique yet but when (and if) it does, correct links will already be there.

@rphmeier
Copy link
Contributor

Doesn't ETC still use morden as a testnet?

@gavofyork
Copy link
Contributor

yeah i think so.

@dstarcev
Copy link
Contributor Author

As @5chdn mentioned, etherscan.io doesn't seem to support morden anymore. https://morden.etherscan.io/ refers to ROPSTEN (Attacked) TESTNET and I am not sure if we should provide links to it.

@5chdn
Copy link
Contributor

5chdn commented Apr 18, 2017

Doesn't ETC still use morden as a testnet?

It's not about removing the morden testnet but the explorer links (as there is none).

@dstarcev
Copy link
Contributor Author

I have updated the PR as the mainnet network id is actually 1.

@jacogr jacogr added the A7-looksgoodcantmerge 🙄 Pull request is reviewed well, but cannot be merged due to conflicts. label Apr 20, 2017
@jacogr
Copy link
Contributor

jacogr commented Apr 20, 2017

Looks good, tested as well. Just waiting on CLA signoff.

@dstarcev
Copy link
Contributor Author

[clabot:check]

@parity-cla-bot
Copy link

It looks like @dstarcev signed our Contributor License Agreement. 👍

Many thanks,

Parity Technologies CLA Bot

@jacogr jacogr added A8-looksgood 🦄 Pull request is reviewed well. and removed A4-clasignoffneeded 📛 Pull request requires author to sign off on CLA before review/merge can begin. A7-looksgoodcantmerge 🙄 Pull request is reviewed well, but cannot be merged due to conflicts. labels Apr 20, 2017
@jacogr jacogr merged commit 6c33b78 into openethereum:master Apr 20, 2017
@ngotchac ngotchac mentioned this pull request May 5, 2017
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@5chdn 5chdn 5chdn left review comments

Assignees
No one assigned
Labels
A8-looksgood 🦄 Pull request is reviewed well.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@dstarcev @parity-cla-bot @rphmeier @gavofyork @5chdn @jacogr @tomusdrw