This repository was archived by the owner on Nov 6, 2020. It is now read-only.
parity_getBlockHeaderByNumber and LightFetch utility #5383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rphmeier
added
A0-pleasereview 🤓
gavofyork
reviewed
Apr 8, 2017
rpc/src/v1/helpers/light_fetch.rs
Outdated
| use ethsync::LightSync; | ||
| use util::{Address, Mutex, Uint, U256}; | ||
|
|
||
| use v1::helpers::{CallRequest as CRequest, errors, dispatch}; |
There was a problem hiding this comment.
consider CRequest -> CallRequestHelper to aid readability.
gavofyork
added
A6-mustntgrumble 💦
|
marking inprogress until resolved. |
gavofyork
added
A3-inprogress ⏳
rphmeier
added
A0-pleasereview 🤓
gavofyork
added
A8-looksgood 🦄
rphmeier
force-pushed
the
block_header_rpc
branch
from
97a8e81 to
e094043
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hand-off to @jacogr
The motivation behind this method is to lower the strain on nodes being polled for latest block info by the UI. Recent headers and total difficulty are always available on the light client, while recent block bodies are not.
Moves some utilities of the
ethRPCs for fetching data either from the local chain or from the network into aLightFetchwhich can be instantiated from various different RPCs.Uses
LightFetchfrom theparityRPC implementation to implementparity_getBlockHeaderByNumber.