Skip to content
This repository was archived by the owner on Nov 6, 2020. It is now read-only.

Add lint:i18n to find missing & extra keys #5290

Merged
merged 2 commits into from
Mar 27, 2017
Merged

Add lint:i18n to find missing & extra keys #5290

merged 2 commits into from
Mar 27, 2017

Conversation

jacogr
Copy link
Contributor

@jacogr jacogr commented Mar 27, 2017

Add npm run lint:i18n reporting the missing keys (found in original, not in translation) as well as any extra keys (found in translation, not found in original)

*** Checking translations for de
  Missing account.button.delete
  Missing account.button.edit
  Missing account.button.password
...
  Missing walletSettings.rejected.busyStep.title
  Missing walletSettings.rejected.title
  Missing web.requestToken
Found 41 keys, missing 465 keys, 0 extraneous keys

*** Checking translations for nl
Found 506 keys, missing 0 keys, 0 extraneous keys

@jacogr jacogr added A0-pleasereview 🤓 Pull request needs code review. M7-ui labels Mar 27, 2017
@ngotchac ngotchac added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Mar 27, 2017
@ngotchac
Copy link
Contributor

Looks good. Would it make sense to output it as a JSON though?

@jacogr
Copy link
Contributor Author

jacogr commented Mar 27, 2017

I'll log an issue for that - honestly still unsure about exactly what would be useful here, so just started with identifying the gaps. (CSV could be useful as well)

@ngotchac
Copy link
Contributor

Okay. Yes I guess JSON would be easy to read if we want to have some kind of metric integration (could display somewhere every languages with the percentage of translation on master)

@jacogr jacogr merged commit a4c5375 into master Mar 27, 2017
@jacogr jacogr deleted the jg-i18n-tools branch March 27, 2017 14:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A8-looksgood 🦄 Pull request is reviewed well.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants