Skip to content
This repository was archived by the owner on Nov 6, 2020. It is now read-only.

CI: test coverage (for core and js) #4832

Merged
merged 4 commits into from
Mar 10, 2017
Merged

CI: test coverage (for core and js) #4832

merged 4 commits into from
Mar 10, 2017

Conversation

General-Beck
Copy link
Contributor

@General-Beck General-Beck commented Mar 9, 2017 •
edited
Loading

@General-Beck General-Beck self-assigned this Mar 9, 2017
@General-Beck General-Beck added the M1-ci 🙉 Continuous integration. label Mar 9, 2017
@rphmeier
Copy link
Contributor

rphmeier commented Mar 9, 2017

AFAIK cov.sh only does coverage for core. What about coverage for UI code?

@General-Beck
Copy link
Contributor Author

@rphmeier do that, then js

@rphmeier
Copy link
Contributor

rphmeier commented Mar 9, 2017

Ok, makes sense.

@rphmeier rphmeier changed the title test coverage CI: test coverage (for core) Mar 9, 2017
@rphmeier rphmeier added the A0-pleasereview 🤓 Pull request needs code review. label Mar 9, 2017
@gavofyork gavofyork added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Mar 10, 2017
@gavofyork gavofyork merged commit 608c0dc into master Mar 10, 2017
@gavofyork gavofyork deleted the coverage branch March 10, 2017 09:12
@General-Beck General-Beck restored the coverage branch March 10, 2017 11:04
@General-Beck
Copy link
Contributor Author

@gavofyork need to check some tests. and empower

@General-Beck General-Beck changed the title CI: test coverage (for core) CI: test coverage (for core and js) Mar 10, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@General-Beck General-Beck

Labels
A8-looksgood 🦄 Pull request is reviewed well. M1-ci 🙉 Continuous integration.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@General-Beck @rphmeier @gavofyork