This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Update Wallet to new Wallet Code #4805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Will add the above instructions to my auto-deploy tool as well. (So it just gets done by click of a button) https://github.com/ethcore/parity/pull/4726 |
jacogr
reviewed
Mar 7, 2017
| return WalletsUtils | ||
| .isWallet(api, address) | ||
| .then((isWallet) => { | ||
| if (!isWallet) { |
There was a problem hiding this comment.
+1 Really happy with this approach. (For both deploy & estimate)
jacogr
reviewed
Mar 7, 2017
| transaction.gasUsed | ||
| ? ( | ||
| <span> | ||
| <span>used</span> |
There was a problem hiding this comment.
Would have made sense to i18n these additions, but no matter, busy with this actual file in my conversion branch, so will be ok.
jacogr
reviewed
Mar 7, 2017
| if (!isEqual(localHashes, this.localHashes)) { | ||
| @action setLocalHashes = (localHashes = []) => { | ||
| // Use slice to make sure they are both Arrays (MobX uses Objects for Observable Arrays) | ||
| if (!isEqual(localHashes.slice(), this.localHashes.slice())) { |
There was a problem hiding this comment.
Not sure which one is more performant from a MobX perspective - .peek() or .slice() (Typically do use the former when it is a known (i.e. on this.) value
|
Ok, happy with it from a code perspective, it needs to go for 1.6 - full end-to-end scenario testing will happen once merged. |
jacogr
added
A8-looksgood 🦄
jacogr
pushed a commit
that referenced
this pull request
Mar 7, 2017
* Update Wallet Version * Update Wallet Library * Update Wallets Bytecodes * Typo * Separate Deploy in Contract API * Use the new Wallet ABI // Update wallet code * WIP .// Deploy from Wallet * Update Wallet contract * Contract Deployment for Wallet * Working deployments for Single Owned Wallet contracts * Linting * Create a Wallet from a Wallet * Linting * Fix Signer transactions // Add Gas Used for transactions * Deploy wallet contract fix * Fix too high gas estimate for Wallet Contract Deploys * Final piece ; deploying from Wallet owned by wallet * Update Wallet Code * Updated the Wallet Codes * Fixing Wallet Deployments * Add Support for older wallets * Linting
This was referenced Mar 7, 2017
Merged
arkpar
pushed a commit
that referenced
this pull request
Mar 8, 2017
* Update Wallet to new Wallet Code (#4805) * Update Wallet Version * Update Wallet Library * Update Wallets Bytecodes * Typo * Separate Deploy in Contract API * Use the new Wallet ABI // Update wallet code * WIP .// Deploy from Wallet * Update Wallet contract * Contract Deployment for Wallet * Working deployments for Single Owned Wallet contracts * Linting * Create a Wallet from a Wallet * Linting * Fix Signer transactions // Add Gas Used for transactions * Deploy wallet contract fix * Fix too high gas estimate for Wallet Contract Deploys * Final piece ; deploying from Wallet owned by wallet * Update Wallet Code * Updated the Wallet Codes * Fixing Wallet Deployments * Add Support for older wallets * Linting * SMS Faucet (#4774) * Faucet * Remove flakey button-index testing * Only display faucet when sms verified (mainnet) * simplify availability checks * WIP * Resuest from verified -> verified * Update endpoint, display response text * Error icon on errors * Parse hash text response * Use /api/:address endpoint * hash -> data * Adjust sms-certified message * Fix SectionList hovering issue (#4749) * Fix SectionList Items hover when <3 items * Even easier... * lint (new)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the UI to use the new Wallet.
Now one can deploy contracts with a Wallet.
The Wallet Library should be deployed to any network where we want to have it.
The bytecode + ABI are in
js/src/contracts/code/wallet.js:walletLibraryandwalletLibraryABI.The deployed address should then be added to the registry with
walletLibraryas a key (the value ofwalletLibraryRegKey). It has been done for Kovan already.