Fix SectionList hovering issue #4749
Conversation
ngotchac
added
A0-pleasereview 🤓
ngotchac
added
A0-pleasereview 🤓
| } | ||
| } | ||
| } | ||
| .item.stretchOn:hover { |
There was a problem hiding this comment.
There is a reason for the shrinking. When the name (Title) is at exactly 33% and you hover over the row the affected item does not shrink and go into text-overflow, rather the browser just shrinks the other card, so you end up with one tiny, one normal and one big. (Chrome)
This is the original implementation, sadly the simplest, sadly broken in edge-cases due to what I think is a browser bug.
jacogr
added
A4-gotissues 💥
|
Again, I played with all lengths of titles and all, and could not find any bug... Please be a bit more specific if possible |
ngotchac
added
A0-pleasereview 🤓
|
Will need to do it after the release crunch is over - will first need to create the issue (as it manifested, could probably mean rolling back to be 100% sure it is what it is) and then go from there. As I said very valid as to why, what the specific circumstances are need to find again. Simpler is always better, which is why we started exactly where you are atm. Also possibly other changes could have squashed it, with no need for the work-around anymore. (So either way, rooting for this, just not taking any risks.) |
|
Ok, did a hacky rollback to an old local WIP branch. My ropsten chain still had problematic instances (under vaults), so got lucky. Something changed somewhere in the containers, even with the 33.33% original, no original non-stretches when updated. However could also spot what you meant with "strange overflow issues, hence the 0 width". (e.g. some additional cases where issues crops up, tested this with accounts - obviously easier since the names are editable) So we seems to cater for both, happy that original/simple can be back. |
jacogr
added
A8-looksgood 🦄
* Fix SectionList Items hover when <3 items * Even easier...
* Update Wallet to new Wallet Code (#4805) * Update Wallet Version * Update Wallet Library * Update Wallets Bytecodes * Typo * Separate Deploy in Contract API * Use the new Wallet ABI // Update wallet code * WIP .// Deploy from Wallet * Update Wallet contract * Contract Deployment for Wallet * Working deployments for Single Owned Wallet contracts * Linting * Create a Wallet from a Wallet * Linting * Fix Signer transactions // Add Gas Used for transactions * Deploy wallet contract fix * Fix too high gas estimate for Wallet Contract Deploys * Final piece ; deploying from Wallet owned by wallet * Update Wallet Code * Updated the Wallet Codes * Fixing Wallet Deployments * Add Support for older wallets * Linting * SMS Faucet (#4774) * Faucet * Remove flakey button-index testing * Only display faucet when sms verified (mainnet) * simplify availability checks * WIP * Resuest from verified -> verified * Update endpoint, display response text * Error icon on errors * Parse hash text response * Use /api/:address endpoint * hash -> data * Adjust sms-certified message * Fix SectionList hovering issue (#4749) * Fix SectionList Items hover when <3 items * Even easier... * lint (new)
Fixes issue where items stretch on a SectionList line while hovering the line but on no item (thus when on a line with < 3 items): eg. in Accounts, Dapps...
Closes https://github.com/ethcore/parity/issues/4665