This repository was archived by the owner on Nov 6, 2020. It is now read-only.
Fix address and accounts links #4491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Failing tests. |
|
Fixed test (and added 2 actually) |
jacogr
reviewed
Feb 9, 2017
| @observable balances = {}; | ||
| @observable localHashes = []; | ||
|
|
||
| constructor (api, withLocalTransactions = false) { | ||
| externalLink = ''; |
There was a problem hiding this comment.
Prefer _externalLink for non-exposed internal variables, i.e. no observable. (As per rest of the class)
jacogr
reviewed
Feb 9, 2017
| const { accounts } = initState.personal; | ||
| const accountAddresses = Object.keys(accounts); | ||
|
|
||
| return () => { |
There was a problem hiding this comment.
Why not a simple
return {
accountAddresses
};
(As opposed to the function?)
There was a problem hiding this comment.
It's only so it doesn't re-render on every Redux dispatched action (since the same Object is thus returned)
|
I'm just wondering if (I may be going blind) |
|
It's mainly for the embedded Parity Bar for the Chrome Extension ! ;) |
jacogr
added
A8-looksgood 🦄
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4314
In Signer and Transaction lists, redirect the links to Parity UI and not Etherscan