Signer provenance #4477
Signer provenance #4477
Conversation
tomusdrw
added
A0-pleasereview 🤓
ethcore/src/trace/db.rs
Outdated
| @@ -305,7 +305,7 @@ impl<T> TraceDatabase for TraceDB<T> where T: DatabaseExtras { | |||
| } | |||
|
|
|||
| fn trace(&self, block_number: BlockNumber, tx_position: usize, trace_position: Vec<usize>) -> Option<LocalizedTrace> { | |||
| let trace_position_deq = trace_position.into_iter().collect(); | |||
| let trace_position_deq = trace_position.into_iter().collect::<VecDeque<usize>>(); | |||
There was a problem hiding this comment.
can be more efficiently done with a simple trace_position.into()
There was a problem hiding this comment.
👍 Good point. Had to touch this line since it wasn't compiling on latest nightly.
| }; | ||
|
|
||
| static propTypes = { | ||
| origin: PropTypes.oneOfType([ |
There was a problem hiding this comment.
I'd prefer having two props, e.g. type and origin here, one containing rpc/ipc/etc and one containing the data necessary to display it. Better to read and cleaner than passing an object as a prop.
There was a problem hiding this comment.
K, will pre-process RPC response.
| expect(shallow( | ||
| <RequestOrigin origin={ { signer: '0x12345' } } />, | ||
| context | ||
| ).text()).to.equal('Requested by UI session<Connect(IdentityIcon) />'); |
There was a problem hiding this comment.
IMO "Requested by from the UI" would be more intuitive.
There was a problem hiding this comment.
Edit: github removes stuff from my comment, sry for the confusion.
both. requested by <identity icon> from the UI.
There was a problem hiding this comment.
But <identity icon> doesn't mean an account, but UI session.
gavofyork
added
A3-inprogress ⏳
|
marked inprogress as build is failing. |
tomusdrw
added
A0-pleasereview 🤓
|
Core portion LGTM |
arkpar
added
A7-looksgoodcantmerge 🙄
tomusdrw
added
A0-pleasereview 🤓
jacogr
added
A8-looksgood 🦄
Exposes signer provenance in RPC and displays it in the UI.
Currently IPC doesn't support metadata extraction, so we cannot properly identify IPC requests yet.
It should be added when paritytech/jsonrpc#17 is implemented.
GUI:
