This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Open popup without attempting inline #4440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacogr
added
A8-looksgood 🦄
jacogr
reviewed
Feb 6, 2017
| @@ -68,6 +68,19 @@ export default class Store { | |||
| installExtension = () => { | |||
| this.setInstalling(true); | |||
|
|
|||
| if (window.location.hostname === 'home.web3.site') { | |||
There was a problem hiding this comment.
Should probably just check for <anything>.web3.site, however it is good getting around the issue until we figure out a way forward.
jacogr
added
A6-mustntgrumble 💦
tomusdrw
added
A0-pleasereview 🤓
jacogr
reviewed
Feb 6, 2017
| const BASE_URL = '.web.web3.site'; | ||
| import { DOMAIN } from './constants'; | ||
|
|
||
| const BASE_URL = `.web${DOMAIN}`; |
jacogr
added
A8-looksgood 🦄
tomusdrw
added a commit
that referenced
this pull request
Feb 6, 2017
* Open popup without attempting inline * Cater for all .web3.site addresses
jacogr
pushed a commit
that referenced
this pull request
Feb 6, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Opening popup outside of a frame processing user action (click event) will cause the popup to be blocked.
This fix only attempts inline installation when on the right domain.