Home landing page #4178

jacogr · 2017-01-16T15:57:47Z

Actions -

Created views/Home that shows the actual components (urls, dapps, news & accounts - all historic)
Add /home route & menubar item (replacing previous non-clickable image). This is now the default landing page.

In action -

https://youtu.be/eGngA2lj3Gk

Additional required dependencies -

*.web.web3.site & history from Parity Node, Persistent tracking of dapps #4302 & https://github.com/ethcore/parity/tree/ethlink
Add utils/dapplink to encode <token+url>.web.web3.site URLs, Web view with web3.site support #4313
Split DappUrlInput component from views/Web, allowing the re-usable entry of a web URL, Web view with web3.site support #4313
Split logic from views/Web into re-usable store, Web view with web3.site support #4313
Split Tabbar Tab component into separate file, Split Tab from TabBar #4318

derhuerst · 2017-01-17T16:44:04Z

js/src/util/ethlink.js

+import base32 from 'base32.js';
+
+// base32 alphabet should match the Rust implementation
+// https://github.com/andreasots/base32/blob/master/src/base32.rs


Would be great to have a non-volatile link to a specific commit in here.

We are not even close to having that - we are still actually in development here and finding what works between the platforms without decoding issues.

(At this point is a align-tests between platforms, push, build binaries and test exercise - that comment is due to "tracking between days" to not lose context.)

jacogr · 2017-02-13T13:31:03Z

Updated.

ngotchac · 2017-02-13T14:15:08Z

The dapps and the accounts looks very similar and I think it would be easier if it were one component. The link and the title should be the only thing that differ, as well as the image. No ?

That's when the cursor is over the dapps zone, but not over a dapp

That's when the cursor is outside the dapps zone

ngotchac · 2017-02-13T14:18:18Z

When the node is not connected, it shows the accounts as unnamed

ngotchac · 2017-02-13T14:27:51Z

js/src/views/Home/Accounts/accounts.js

+      >
+        <Link
+          className={ styles.link }
+          to={ `/${history.type === 'wallet' ? 'wallet' : 'accounts'}/${history.entry}` }


We might want to connect this component to the Redux state, so it can directly check if it's an Account, a Wallet or an address. The link URL would be generated accordingly.
The point being that if I visit an Account and then delete it, it would still show up in the history and the link would be broken. The parent component could be connected not to render this deleted Account though

+1 Good point.

ngotchac · 2017-02-13T14:32:56Z

js/src/views/Home/News/news.js

+      body: item.style ? (item.style.body || {}) : {},
+      head: item.style ? (item.style.head || {}) : {},
+      tags: item.style ? (item.style.tags || {}) : {}
+    };


Why not simply { ...item.style } ? Could filter which key with lodash/omitBy if necessary

I think this is due to evolution over time and figuring out what makes sense. { ...item.style } would be preferable.

ngotchac · 2017-02-13T14:35:12Z

js/src/views/Home/News/news.js

+    );
+  }
+
+  retrieveNews () {


Can't we have a simple MobX store for that ? Would be great to have it as a singleton to be able to cache the result (and update if necessary). When you switch back to the home page without leaving the UI, there is always at least 1 sec without the news displayed.

Yes, been to-and-fro-ing this one in my head. Feels like overkill (store for 1 call), however the singleton actually does make sense here, just because of the delay. Will update.

ngotchac · 2017-02-13T14:38:36Z

js/src/views/Home/News/news.js

+    return (
+      <SectionList
+        className={ styles.news }
+        items={ newsItems }


Is it limited to 3 news ?

More sections goes into the next line, so there can be as many as we want.

ngotchac · 2017-02-13T14:43:16Z

js/src/views/Home/Urls/urls.js

+    if (extensionStore.hasExtension) {
+      window.open(this.props.store.currentUrl, '_blank');
+    } else {
+      router.push('/web');


Could it be a proper a link instead ? As it's just a link, using the standard attributes sounds a bit more logical (just thinking about users with no extension that want to ctrl+click on the link to open the dapp in a new tab)

It becomes quite hairy and very messy prior to <base36>.web.web3.site support for the internal dapps -

Internal vs external to use Link (internal) and a (external)

Still need to set set the currentUrl in the Webstore before opening /web

Could probably re-look at the implementation with an issue, here though I am not going to touch everything down from Web/Store and re-imagine the world. So I would suggest logging as an enhancement.

Yes ok, I haven't seen that the Browser dapp don't take into account the real browser url.

jacogr · 2017-02-13T16:21:09Z

Updated.

UI overlaps, pulled in my changes from the Vaults branch re Container.
Upon connecting, doesn't show Home page
News into seperate singleton store
Items styles now expanded inline
Auto-detection of link type based on Redux info

As for similar components, in isolation, yes. However these would need to be replaced by standard summary components as soon as we get to the Accounts/Address/Contract/Dapp overlay-change PRs. (So really don't want to add generic component work here to turf it 3 PRs down the line especially without seeing what the needs are across views.)

ngotchac

Okay, looks good now. The only thing is when you click on a dapp, and then on Parity to go back to the UI, it navigates to the dapp view, instead of the previous home view

jacogr added 7 commits January 16, 2017 11:17

Home entry point (basics)

030116e

WIP store for web

092a183

Add DappUrlInput component

566dc44

Merge branch 'master' into jg-home

8cf9f22

Updated tests

64cbb41

WIP store update

ea74460

Merge branch 'master' into jg-home

e3d8fcf

jacogr added A3-inprogress ⏳ Pull request is in progress. No review needed at this stage. M7-ui labels Jan 16, 2017

jacogr changed the title ~~Jg home~~ Home landing page Jan 16, 2017

jacogr added 13 commits January 16, 2017 18:01

Adjust styling

548f2b7

Add home tab

51dcd3d

Merge branch 'master' into jg-home

1911426

Collapse first/last without extra divs

16e9ab1

Navigation actually navigates

f18d9db

styling

8e12674

Merge branch 'master' into jg-home

ab73770

Encoding of ethlink.io URLs

4acc0e4

encodedUrl setup

b5c184c

Merge branch 'master' into jg-home

977663c

base58 encoded URLs

39b2d92

Added decoding, updated tests to Parity-compliant

3d3f3e1

Base32 (synced with Rust implementation via tests)

c4a989d

derhuerst reviewed Jan 17, 2017

View reviewed changes

jacogr added 6 commits January 18, 2017 09:30

Merge branch 'master' into jg-home

77c3c47

Split URL into 63 character chunks

d878a63

Fix store test

b2fe7e0

Cleanups

c12964f

s/ethlink/dapplink/

6a1395d

Display app navigation & histroy

f295784

jacogr added 2 commits February 13, 2017 14:20

s/Web Apps via URL/Web Apps/ (PR grumble)

757f3b5

Store recent wallets (PR grumble)

7c10643

jacogr added A0-pleasereview 🤓 Pull request needs code review. and removed A3-inprogress ⏳ Pull request is in progress. No review needed at this stage. labels Feb 13, 2017

ngotchac reviewed Feb 13, 2017

View reviewed changes

ngotchac added A4-gotissues 💥 Pull request is reviewed and has significant issues which must be addressed. and removed A0-pleasereview 🤓 Pull request needs code review. labels Feb 13, 2017

jacogr added 10 commits February 13, 2017 16:03

Merge branch 'master' into jg-home

d3e4052

Simplify inline style matching (PR comment)

1a89390

Add store for new retrieval

ed0d517

Add missing observer

595861b

Auto-link based on account type

34ad4af

Fix UI overlaps

ccd4d17

Extra spacing

fbef7ef

Only show account when accountInfo is available

2dedfcd

Align timestamp line-heights

dd90f2e

Fix tests

d9738e5

jacogr added A0-pleasereview 🤓 Pull request needs code review. and removed A4-gotissues 💥 Pull request is reviewed and has significant issues which must be addressed. labels Feb 13, 2017

jacogr added 2 commits February 13, 2017 17:42

Update tests

596ebaa

Really fix failing test (check for Connect(Account))

6a81156

ngotchac approved these changes Feb 13, 2017

View reviewed changes

ngotchac added A6-mustntgrumble 💦 Pull request has areas for improvement. The author need not address them before merging. and removed A0-pleasereview 🤓 Pull request needs code review. labels Feb 13, 2017

jacogr merged commit 63d2cfc into master Feb 14, 2017

jacogr deleted the jg-home branch February 14, 2017 07:29

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Home landing page #4178

Home landing page #4178

jacogr commented Jan 16, 2017 •

edited

Loading

derhuerst Jan 17, 2017

jacogr Jan 18, 2017 •

edited

Loading

jacogr commented Feb 13, 2017

ngotchac commented Feb 13, 2017 •

edited

Loading

ngotchac commented Feb 13, 2017

ngotchac Feb 13, 2017

jacogr Feb 13, 2017

ngotchac Feb 13, 2017

jacogr Feb 13, 2017

ngotchac Feb 13, 2017

jacogr Feb 13, 2017

ngotchac Feb 13, 2017

jacogr Feb 13, 2017 •

edited

Loading

ngotchac Feb 13, 2017

jacogr Feb 13, 2017 •

edited

Loading

ngotchac Feb 13, 2017

jacogr commented Feb 13, 2017

ngotchac left a comment

Home landing page #4178

Home landing page #4178

Conversation

jacogr commented Jan 16, 2017 • edited Loading

Choose a reason for hiding this comment

jacogr Jan 18, 2017 • edited Loading

Choose a reason for hiding this comment

jacogr commented Feb 13, 2017

ngotchac commented Feb 13, 2017 • edited Loading

ngotchac commented Feb 13, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jacogr Feb 13, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jacogr Feb 13, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jacogr commented Feb 13, 2017

ngotchac left a comment

Choose a reason for hiding this comment

jacogr commented Jan 16, 2017 •

edited

Loading

jacogr Jan 18, 2017 •

edited

Loading

ngotchac commented Feb 13, 2017 •

edited

Loading

jacogr Feb 13, 2017 •

edited

Loading

jacogr Feb 13, 2017 •

edited

Loading