This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
New jsonrpc-core with futures and metadata support #3859
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
December 13, 2016 14:54
Conflicts: Cargo.lock Cargo.toml parity/dapps.rs parity/rpc.rs parity/signer.rs
Conflicts: rpc/src/v1/impls/traces.rs rpc/src/v1/traits/traces.rs
tomusdrw
added
A0-pleasereview 🤓
Conflicts: Cargo.lock rpc/src/v1/impls/eth.rs signer/src/tests/mod.rs
|
Changes Unknown when pulling 4f494d5 on rpc-futures into ** on master**. |
|
looks reasonable to me. |
|
will need rebase... |
Conflicts: Cargo.lock Cargo.toml parity/rpc_apis.rs parity/run.rs rpc/Cargo.toml rpc/src/lib.rs rpc/src/v1/tests/mocked/parity_set.rs rpc/src/v1/traits/parity_set.rs
|
still some conflicts... |
added 4 commits
December 17, 2016 17:05
Conflicts: Cargo.lock rpc/src/v1/impls/eth.rs
rphmeier
reviewed
Dec 19, 2016
| #[derive(Clone, Debug, PartialEq)] | ||
| pub enum Origin { | ||
| /// RPC server | ||
| Rpc, |
There was a problem hiding this comment.
What does an origin of Rpc signify? All requests are RPC requests.
There was a problem hiding this comment.
It's JSON-RPC over HTTP coming from standalone JSON-RPC server (not dapps). It's initialized in crate rpc and also parity/rpc.rs so I thought that it makes sense to use this name to indentify it.
tomusdrw
added
the
A1-onice 🌨
|
IMHO it shouldn't go to |
|
Changes Unknown when pulling 06c9be9 on rpc-futures into ** on master**. |
arkpar
added
the
A7-looksgoodcantmerge 🙄
Conflicts: Cargo.lock Cargo.toml dapps/src/lib.rs dapps/src/tests/helpers.rs parity/dapps.rs parity/rpc_apis.rs parity/run.rs rpc/Cargo.toml rpc/src/lib.rs rpc/src/v1/impls/parity_set.rs
gavofyork
added
A1-onice 🌨
added 2 commits
December 23, 2016 22:25
Conflicts: Cargo.lock dapps/src/rpc.rs
|
Changes Unknown when pulling 969f5c0 on rpc-futures into ** on master**. |
Closed
Merged
rphmeier
added
A0-pleasereview 🤓
|
requires rebase |
Conflicts: Cargo.lock dapps/src/lib.rs dapps/src/tests/helpers/mod.rs parity/dapps.rs parity/rpc.rs parity/run.rs rpc/src/lib.rs rpc/src/v1/impls/eth.rs rpc/src/v1/impls/traces.rs rpc/src/v1/tests/mocked/signer.rs stratum/src/lib.rs util/fetch/src/client.rs
tomusdrw
added
A0-pleasereview 🤓
arkpar
added
A8-looksgood 🦄
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
jsonrpc-corewas rewritten to useFuturesto handle async code.Metadatais now part ofjsonrpc-core, so there is no need to do middlewares and augmentationThis will allow us to handle requests coming from different transports in a more elegant way (for instance
eth_accountscan return all accounts for HTTP and IPC and only alter the list for dapps).