This repository was archived by the owner on Nov 6, 2020. It is now read-only.
fixed #1889, .DS_Store is no longer treated as key file #1892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
debris
added
A0-pleasereview 🤓
|
Wouldn't it be better to only open .json files? |
|
key file name does not contain |
|
Or ignore hidden files at least. It's the same story with |
|
Why do we panic instead of just displaying a warning that key file couldn't have been loaded? |
Technically it's not a panic, but quick exit. We assume that our keys must be valid. We display warnings only if geth keys cannot be imported. |
|
Changes Unknown when pulling bf79187 on fixed_dsstore into * on master*. |
NikVolf
added
A8-looksgood 🦄
|
I'm in favour of displaying a warning, rather than outright bailing, when a file in our keys directory cannot be properly loaded as a key. Bailing should be reserved for unrecoverable errors rather than uncertainty over whether the user actually intended a particular file to be loaded as a key. |
arkpar
added
A4-gotissues 💥
|
does not build |
debris
added
A0-pleasereview 🤓
NikVolf
added
A8-looksgood 🦄
arkpar
pushed a commit
that referenced
this pull request
Aug 12, 2016
arkpar
added a commit
that referenced
this pull request
Aug 12, 2016
* RPC errors & logs (#1845) * Refactoring errors in RPC * Updating jsonrpc-core * Fixing code_at * Avoid mentioning obvious segments in proof [ci:skip] * fixed cache_manager lock order * Purging .derefs, fixing clippy warnings. (#1890) * Fixing clippy warnings * Purging derefs * Simplifying engine derefs * Simplifying more engine derefs * Adding more details to miner log * fixed #1889, .DS_Store is no longer treated as key file (#1892) * fixed #1889, .DS_Store is no longer treated as key file * ethstore filters directories, hidden files and common system files * fixed compiling * fix regression with geth dir * fix regression with geth dir * Fix ipc compilation and add ipc feature to test targets (#1902) * fix compilation and add it to the ci run * no separator? * use quotes and spaces * RocksDB version bump * Don't return deleted nodes that are not yet flushed (#1908) * polling & connection timeouts (#1910) * Peers RPC + UI displaying active/connected/max peers (#1915) * Peers API * Bumping Parity-UI * Fixing tests * Save nodes removed from backing_overlay until commit (#1917)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.