Skip to content
This repository was archived by the owner on Nov 6, 2020. It is now read-only.

Fixed reported max height and transaction propagation #1852

Merged
merged 2 commits into from
Aug 5, 2016
Merged

Fixed reported max height and transaction propagation #1852

merged 2 commits into from
Aug 5, 2016

Conversation

arkpar
Copy link
Collaborator

@arkpar arkpar commented Aug 5, 2016

fixes #1844

@arkpar arkpar added the A0-pleasereview 🤓 Pull request needs code review. label Aug 5, 2016
@coveralls
Copy link

coveralls commented Aug 5, 2016 •
edited
Loading

Coverage Status

Coverage decreased (-0.09%) to 86.606% when pulling c443d9d on sync-height into 725d320 on master.

@gavofyork gavofyork added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Aug 5, 2016
@gavofyork
Copy link
Contributor

tests failing:

  • chain::tests::handles_peer_new_block_empty
  • chain::tests::handles_peer_new_block_malformed

@gavofyork gavofyork added A4-gotissues 💥 Pull request is reviewed and has significant issues which must be addressed. and removed A8-looksgood 🦄 Pull request is reviewed well. labels Aug 5, 2016
@arkpar arkpar added A8-looksgood 🦄 Pull request is reviewed well. and removed A4-gotissues 💥 Pull request is reviewed and has significant issues which must be addressed. labels Aug 5, 2016
@coveralls
Copy link

coveralls commented Aug 5, 2016 •
edited
Loading

Coverage Status

Coverage increased (+0.05%) to 86.744% when pulling 53c45c7 on sync-height into 725d320 on master.

@gavofyork gavofyork merged commit 46a988d into master Aug 5, 2016
@gavofyork gavofyork deleted the sync-height branch August 5, 2016 15:01
arkpar added a commit that referenced this pull request Aug 5, 2016
@arkpar
Fixed reported max height and transaction propagation (#1852)
3b36f88 
* Fixed max height and transaction propagation

* Fixed tests
gavofyork pushed a commit that referenced this pull request Aug 5, 2016
@arkpar @gavofyork
Backport fixes to stable (#1855)
aa9b152 
* Fix up the VM trace.

* Fix test.

* Fix state not using "account_starting_nonce" (#1830)

* failng test

* use account_starting_nonce instead of zero

* simplier test

* jsons are getting closer

* incorrect test client and incorrect tests fix

* null_morden is using 0x0 starting nonce

* replaced json with the correct one

* superwhatever line

* Bump json-ipc-server again (#1839)

* bump ipc version

* bumping once more

* v1.2.4

* Fixed reported max height and transaction propagation (#1852)

* Fixed max height and transaction propagation

* Fixed tests
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
A8-looksgood 🦄 Pull request is reviewed well.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Reported max block height is from a forked chain
3 participants
@arkpar @coveralls @gavofyork