This repository was archived by the owner on Nov 6, 2020. It is now read-only.
Fixing clippy stuff #170
Merged
Fixing clippy stuff #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Some(v) => return Some(v.clone()), | ||
| None => () | ||
| if let Some(v) = read.get(hash) { | ||
| return Some(v.clone()); |
There was a problem hiding this comment.
even better:
read.get(hash).map(Clone::clone)There was a problem hiding this comment.
example:
http://is.gd/GGPDVg
There was a problem hiding this comment.
nvm. I haven't noticed that this is quick return.
Conflicts: src/service.rs src/views.rs
Conflicts: util/src/lib.rs
Conflicts: util/src/rlp/rlptraits.rs
| @@ -24,6 +24,7 @@ heapsize = "0.2" | |||
| itertools = "0.4" | |||
| slab = { git = "https://github.com/arkpar/slab.git" } | |||
| sha3 = { path = "sha3" } | |||
| clippy = "*" # Always newest, since we use nightly | |||
There was a problem hiding this comment.
I read yesterday, that crates.io will start banning crates using wildcards starting at 22 January
debris
added
A8-looksgood 🦄
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still working progress it would be good to discuss couple of things.
Most commonly abused:
https://github.com/Manishearth/rust-clippy/wiki#explicit_iter_loop
https://github.com/Manishearth/rust-clippy/wiki#single_match
https://github.com/Manishearth/rust-clippy/wiki#match_ref_pats
https://github.com/Manishearth/rust-clippy/wiki#option_map_unwrap_or
https://github.com/Manishearth/rust-clippy/wiki#wrong_self_convention