This repository was archived by the owner on Nov 6, 2020. It is now read-only.
Parallel block body download #1659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
not sure i fully understand the logic, but does seem to be doing roughly the right thing. |
|
Currently we only download bodies for the headers in the first subchain. This change allows idle peers to download all missing bodies, while still prioritizing those in the front of the queue. |
|
I've been testing this branch on zero.parity.io for 2 days, no issues so far. |
| } | ||
| if !self.downloading_bodies.contains(h) { | ||
| needed_bodies.push(h.clone()); | ||
| self.downloading_bodies.insert(h.clone()); |
There was a problem hiding this comment.
entry API could save a HashSet lookup here
There was a problem hiding this comment.
HashSet does not have one
gavofyork
added
A8-looksgood 🦄
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More aggressive parallel downloading of block bodies.