Allow RPC to use solc to compile solidity #1607
Conversation
[si:skip]
| .stdout(Stdio::piped()) | ||
| .stderr(Stdio::null()) | ||
| .spawn(); | ||
| if let Ok(mut child) = maybe_child { |
There was a problem hiding this comment.
Most of the errors are discarded anyway, maybe it would look better using .and_then ?
There was a problem hiding this comment.
not sure - i think we will still end up with a scope-triangle anyway since it's not a pipeline of data refinement. we don't favour .for_each over for, so i'm not sure why we'd favour .and_then over if let.
There was a problem hiding this comment.
Hmm, I think and_then should keep the indentation on the same level, but not really forcing it - just a hint.
There was a problem hiding this comment.
if it were a pure data refinement pipeline, then for sure. with a lot of faff currying locals around in tuples, i guess if might work, but the code would be less readable. feel free to demonstrate if you reckon otherwise.
tomusdrw
added
A5-grumble 🔥
gavofyork
changed the title
gavofyork
added
A0-pleasereview 🤓
gavofyork
changed the title
|
Changes Unknown when pulling c0dca74 on use-solc into * on master*. |
arkpar
added
A8-looksgood 🦄
No description provided.