This repository was archived by the owner on Nov 6, 2020. It is now read-only.
Fix "pending" parameter on RPC block requests #1602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| block_rlp.append(&self.transactions); | ||
| block_rlp.append(&self.uncles); | ||
| block_rlp.out() | ||
| } |
There was a problem hiding this comment.
should take seal parameter. i would find this useful for minor snapshotting cleanup
tomusdrw
added
A5-grumble 🔥
gavofyork
added
A0-pleasereview 🤓
arkpar
added
A8-looksgood 🦄
|
Changes Unknown when pulling 5d42c58 on fix_pending into * on master*. |
arkpar
pushed a commit
that referenced
this pull request
Jul 15, 2016
* Initial commit. * Pending blocks work. * Address grumbles. * Fix up for new API.
arkpar
added a commit
that referenced
this pull request
Jul 15, 2016
* Remove soft-fork stuff. * Fix tests. * Fix "pending" parameter on RPC block requests (#1602) * Initial commit. * Pending blocks work. * Address grumbles. * Fix up for new API. * Fixed test
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.