Skip to content
This repository was archived by the owner on Nov 6, 2020. It is now read-only.

give appveyor some breath #1475

Merged
merged 1 commit into from
Jun 28, 2016
Merged

give appveyor some breath #1475

merged 1 commit into from
Jun 28, 2016

Conversation

debris
Copy link
Collaborator

@debris debris commented Jun 28, 2016

As described in https://www.appveyor.com/docs/branches. We have the same configuration on travis.

@debris debris added the A0-pleasereview 🤓 Pull request needs code review. label Jun 28, 2016
@gavofyork gavofyork added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Jun 28, 2016
@NikVolf
Copy link
Contributor

NikVolf commented Jun 28, 2016

@debris
they are configured already in web configuration tool like this, btw
but this is more valid place i guess

@debris
Copy link
Collaborator Author

debris commented Jun 28, 2016

@NikVolf I think web config does not work if there is appveyor.yml file. That's why all branches are being build even before making a pull request

@NikVolf
Copy link
Contributor

NikVolf commented Jun 28, 2016

@debris i think they are not working now (exactly in this pr) :)

@NikVolf NikVolf added A7-looksgoodcantmerge 🙄 Pull request is reviewed well, but cannot be merged due to conflicts. and removed A8-looksgood 🦄 Pull request is reviewed well. labels Jun 28, 2016
@debris
Copy link
Collaborator Author

debris commented Jun 28, 2016

weird... docs

@debris
Copy link
Collaborator Author

debris commented Jun 28, 2016

@NikVolf
Copy link
Contributor

NikVolf commented Jun 28, 2016

@gavofyork - i can't access repo settings

@gavofyork
Copy link
Contributor

should be done.

@NikVolf NikVolf added A8-looksgood 🦄 Pull request is reviewed well. and removed A7-looksgoodcantmerge 🙄 Pull request is reviewed well, but cannot be merged due to conflicts. labels Jun 28, 2016
@NikVolf
Copy link
Contributor

NikVolf commented Jun 28, 2016

let's give it a try

@NikVolf NikVolf merged commit 91aee53 into master Jun 28, 2016
@debris debris deleted the appveyor_choking branch June 28, 2016 22:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A8-looksgood 🦄 Pull request is reviewed well.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants