This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Configurable rocksdb cache size #1348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -155,6 +155,7 @@ Footprint Options: | |||
| --cache MEGABYTES Set total amount of discretionary memory to use for | |||
| the entire system, overrides other cache and queue | |||
| options. | |||
| --db-cache-size MEGABYTE Database cache size. | |||
There was a problem hiding this comment.
Perhaps this should be a single --cache options with 20% going to blockchain cache and 80% to db cache, actual ratio needs research though
There was a problem hiding this comment.
The ratio could also be configurable in that case.
There was a problem hiding this comment.
probably later if ratio is not known
database cache was never included in this parameter while being the rocksdb default
arkpar
added
A6-mustntgrumble 💦
NikVolf
added
A0-pleasereview 🤓
arkpar
added
A8-looksgood 🦄
NikVolf
added
A3-inprogress ⏳
|
for some reason travis does not run |
|
Seems to be in the queue: https://travis-ci.org/ethcore/parity/builds/138874746 |
NikVolf
added
A8-looksgood 🦄
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.