This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Write queue to speed-up db ipc #1160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
|
|
||
| unsafe impl Send for Database {} |
There was a problem hiding this comment.
it's about upstream wrapper, cause it does not explicitly says it is Sync+Send
There was a problem hiding this comment.
you could wrap the iterators in an UnsafeCell rather than RwLock so all accesses have to be made explicitly unsafe and are more likely to be checked
NikVolf
added
A3-inprogress ⏳
NikVolf
added
A0-pleasereview 🤓
| Write(Vec<u8>), | ||
| } | ||
|
|
||
| pub struct WriteQueue { |
There was a problem hiding this comment.
should be called WriteCache
| while removed_so_far < amount { | ||
| if self.cache.len() == 0 { break; } | ||
| let removed_key = { | ||
| let (key, cache_entry) = self.cache.iter().nth(0).unwrap(); |
There was a problem hiding this comment.
.expect
prove or remove.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Benches actually fail to reflect the speedup because it's about multithreaded writes&flushes, but on my pc sync speed is back to the level of master