Skip to content
This repository was archived by the owner on Nov 6, 2020. It is now read-only.

Clean up serde rename and use rename_all = camelCase when possible #9823

Merged
merged 13 commits into from
Oct 29, 2018
Merged

Clean up serde rename and use rename_all = camelCase when possible #9823

merged 13 commits into from
Oct 29, 2018

Conversation

sorpaas
Copy link
Collaborator

@sorpaas sorpaas commented Oct 29, 2018

This cleans up all cases where:

  • Use rename_all = camelCase whenever possible.
  • Remove unnecessary rename.

@sorpaas sorpaas added A0-pleasereview 🤓 Pull request needs code review. M2-config 📂 Chain specifications and node configurations. labels Oct 29, 2018
@sorpaas sorpaas added this to the 2.2 milestone Oct 29, 2018
ordian
ordian reviewed Oct 29, 2018
View reviewed changes
rpc/src/v1/types/trace.rs Outdated
EmptyStep,
/// External (attributed as part of an external protocol)
#[serde(rename="external")]
#[serde(rename = "external")]

This comment was marked as resolved.

Sign in to view

rpc/src/v1/types/pubsub.rs Outdated
NewPendingTransactions,
/// Node syncing status subscription.
#[serde(rename="syncing")]
#[serde(rename = "syncing")]

This comment was marked as resolved.

Sign in to view

rpc/src/v1/types/trace.rs Outdated
DelegateCall,
/// Static call
#[serde(rename="staticcall")]
#[serde(rename = "staticcall")]

This comment was marked as resolved.

Sign in to view

rpc/src/v1/types/node_kind.rs Outdated
Full,
/// A light node does a minimal header sync and fetches data as needed
/// from the network.
#[serde(rename="light")]
#[serde(rename = "light")]

This comment was marked as resolved.

Sign in to view

rpc/src/v1/types/node_kind.rs Outdated
Personal,
/// A public, open node.
#[serde(rename="public")]
#[serde(rename = "public")]

This comment was marked as resolved.

Sign in to view

json/src/spec/validator_set.rs Outdated
Contract(Address),
/// A map of starting blocks for each validator set.
#[serde(rename="multi")]
#[serde(rename = "multi")]

This comment was marked as resolved.

Sign in to view

json/src/spec/seal.rs Outdated
Tendermint(TendermintSeal),
/// Generic seal.
#[serde(rename="generic")]
#[serde(rename = "generic")]

This comment was marked as resolved.

Sign in to view

json/src/spec/engine.rs Outdated
AuthorityRound(AuthorityRound),
/// Tendermint engine.
#[serde(rename="tendermint")]
#[serde(rename = "tendermint")]

This comment was marked as resolved.

Sign in to view

json/src/spec/builtin.rs Outdated
Modexp(Modexp),
/// Pricing for alt_bn128_pairing exponentiation.
#[serde(rename="alt_bn128_pairing")]
#[serde(rename = "alt_bn128_pairing")]

This comment was marked as resolved.

Sign in to view

whisper/src/rpc/types.rs Outdated
Public(Public),
#[serde(rename="identity")]
#[serde(rename = "identity")]

This comment was marked as resolved.

Sign in to view

@ordian ordian modified the milestones: 2.2, 2.3 Oct 29, 2018
andresilva
andresilva approved these changes Oct 29, 2018
View reviewed changes
Copy link
Contributor

@andresilva andresilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 👍

ordian
ordian approved these changes Oct 29, 2018
View reviewed changes
Copy link
Member

@ordian ordian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ordian ordian added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Oct 29, 2018
ordian
ordian reviewed Oct 29, 2018
View reviewed changes
json/src/spec/engine.rs
@@ -27,6 +27,7 @@ pub enum Engine {
/// Instantly sealing engine.
InstantSeal(Option<InstantSeal>),
/// Ethash engine.
#[serde(rename = "Ethash")]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@ordian ordian modified the milestones: 2.3, 2.2 Oct 29, 2018
@ordian ordian mentioned this pull request Oct 29, 2018
Merged
@sorpaas sorpaas merged commit 05be4b5 into master Oct 29, 2018
@sorpaas sorpaas deleted the sp-rename branch October 29, 2018 15:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ordian ordian ordian approved these changes

@andresilva andresilva andresilva approved these changes

Assignees
No one assigned
Labels
A8-looksgood 🦄 Pull request is reviewed well. M2-config 📂 Chain specifications and node configurations.
Projects
None yet
Milestone
2.2
Development

Successfully merging this pull request may close these issues.
3 participants
@sorpaas @andresilva @ordian