Skip to content
This repository was archived by the owner on Nov 6, 2020. It is now read-only.

ci: remove failing tests for android, windows, and macos #9788

Merged
merged 3 commits into from
Nov 1, 2018
Merged

ci: remove failing tests for android, windows, and macos #9788

merged 3 commits into from
Nov 1, 2018

Conversation

5chdn
Copy link
Contributor

@5chdn 5chdn commented Oct 20, 2018

No description provided.

@5chdn 5chdn added A0-pleasereview 🤓 Pull request needs code review. B1-patch-beta 🕷🕷 M1-ci 🙉 Continuous integration. B0-patch-stable 🕷 Pull request should also be back-ported to the stable branch. labels Oct 20, 2018
@5chdn 5chdn added this to the 2.2 milestone Oct 20, 2018
This was referenced Oct 23, 2018
Merged
Merged
niklasad1
niklasad1 approved these changes Oct 23, 2018
View reviewed changes
Copy link
Collaborator

@niklasad1 niklasad1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally, we should run them IMO but I understand if this is annoying for every PR before we have fixed them.

Can we add something that runs these pipelines on master once every week or something and notifies us?

@niklasad1
Copy link
Collaborator

niklasad1 commented Oct 24, 2018 •
edited
Loading

FYI, it looks like the android pipeline is fixed now i.e, it compiles.

However, the issue is now running the tests but should be enough to compile-test it IMO and seems to be some mismatch between which linker to use since we are cross-compiling!

@5chdn
Copy link
Contributor Author

5chdn commented Oct 26, 2018

Where is Android fixed?

@niklasad1
Copy link
Collaborator

@5chdn
I think the jsonrpc updates in #9657 fixed it. I compiled parity in the android-docker image successfully!

@5chdn
Copy link
Contributor Author

5chdn commented Oct 26, 2018

Ok let me rebase this.

@niklasad1
Copy link
Collaborator

that's weird must be something with configuration because locally on my machine:

$ cargo build --target armv7-linux-androideabi
$ file target/armv7-linux-androideabi/debug/parity
target/armv7-linux-androideabi/debug/parity: ELF 32-bit LSB shared object, ARM, EABI5 version 1 (SYSV), dynamically linked, interpreter /system/bin/linker, not stripped

@5chdn
Copy link
Contributor Author

5chdn commented Oct 27, 2018

It compiles fine, you are right, it's a CI issue, probably not correctly cleaning up the builds between different pipes. I'll escalate to devops.

@5chdn 5chdn modified the milestones: 2.2, 2.3 Oct 29, 2018
andresilva
andresilva reviewed Oct 31, 2018
View reviewed changes
Copy link
Contributor

@andresilva andresilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this mean we won't build Windows or Darwin on PRs? We've had issues in the past with build issues on Windows that we only caught when we wanted to do a release. Can we easily update this so that we still build for these platforms but don't run the tests?

@5chdn
Copy link
Contributor Author

5chdn commented Nov 1, 2018

@andresilva we will get a new pipeline soon anyways. I just want to get rid of the tests on these machines as this clogs the pipelines too much.

@5chdn 5chdn merged commit 570215a into master Nov 1, 2018
@5chdn 5chdn deleted the a5-ci-tests branch November 1, 2018 10:06
@5chdn 5chdn added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Nov 1, 2018
This was referenced Nov 1, 2018
Merged
Merged
5chdn added a commit that referenced this pull request Nov 1, 2018
@5chdn
ci: remove failing tests for android, windows, and macos (#9788)
f77858b 
* ci: remove failing tests for android, windows, and macos

* ci: restore android build jobs
5chdn added a commit that referenced this pull request Nov 1, 2018
@5chdn
ci: remove failing tests for android, windows, and macos (#9788)
b958500 
* ci: remove failing tests for android, windows, and macos

* ci: restore android build jobs
5chdn added a commit that referenced this pull request Nov 1, 2018
@5chdn
version: mark 2.1.5 stable (#9821)
aad068d 
* version: mark 2.1.5 stable

* ci: remove failing tests for android, windows, and macos (#9788)

* ci: remove failing tests for android, windows, and macos

* ci: restore android build jobs

* Move state root verification before gas used (#9841)

* Classic.json Bootnode Update (#9828)

* fix: Update bootnodes list to only responsive nodes

* feat: Add more bootnodes to classic.json list

* feat: Add retested bootnodes
5chdn added a commit that referenced this pull request Nov 2, 2018
@5chdn
version: mark 2.2.0 beta (#9820)
5a7e54f 
* version: mark 2.2.0 beta

* ci: remove failing tests for android, windows, and macos (#9788)

* ci: remove failing tests for android, windows, and macos

* ci: restore android build jobs

* Move state root verification before gas used (#9841)

* Classic.json Bootnode Update (#9828)

* fix: Update bootnodes list to only responsive nodes

* feat: Add more bootnodes to classic.json list

* feat: Add retested bootnodes

* Implement NoProof for json tests and update tests reference (replaces #9744) (#9814)

* Update test reference.
Block test are really not working so I disabled a few by commenting
directly in source.

* Move ethtest commit cursor.

* Implements 'NoProof' engine from ethereum/tests#464 .

Since tests has been regenerated those one were failing on block
difficulty check.

Update ethereum/tests, waiting for cost fix (block test are still
commented).

* Update tests submodule reference to latest (all test passing except an
identified case).
Fix block reward of constantinople json.

* Restore broken test by using old json tests files.

* Use CanonNoSeal instead of a custom engine, still have to include some
additional tests code.

* Gas upper limit check in json_chain test was bad, moving the test to
verification, the test is running in `verify_header_param`.
Note that test was previously only for ethash, and now for any engine.

* Restore old behavior (gas uper limit only for ethash engine), at the
cost of an additional trait method.

* Proper rpc test fix.

* Update tests submodule, add SStore bug tests.

* Fix json issue tabulation.
Update tests submodule to latest master (lot of new sstore tests
passing)

* Switch ethereum/tests to tag 6.0.0-beta.1 (no tests changes from latest
synch).

* Display hex with separator, use indirection instead of clone for copy
types.
DemiMarie pushed a commit to poanetwork/parity-ethereum that referenced this pull request Jan 23, 2019
@5chdn @DemiMarie
version: mark 2.2.0 beta (openethereum#9820)
37e0b54 
* version: mark 2.2.0 beta

* ci: remove failing tests for android, windows, and macos (openethereum#9788)

* ci: remove failing tests for android, windows, and macos

* ci: restore android build jobs

* Move state root verification before gas used (openethereum#9841)

* Classic.json Bootnode Update (openethereum#9828)

* fix: Update bootnodes list to only responsive nodes

* feat: Add more bootnodes to classic.json list

* feat: Add retested bootnodes

* Implement NoProof for json tests and update tests reference (replaces openethereum#9744) (openethereum#9814)

* Update test reference.
Block test are really not working so I disabled a few by commenting
directly in source.

* Move ethtest commit cursor.

* Implements 'NoProof' engine from ethereum/tests#464 .

Since tests has been regenerated those one were failing on block
difficulty check.

Update ethereum/tests, waiting for cost fix (block test are still
commented).

* Update tests submodule reference to latest (all test passing except an
identified case).
Fix block reward of constantinople json.

* Restore broken test by using old json tests files.

* Use CanonNoSeal instead of a custom engine, still have to include some
additional tests code.

* Gas upper limit check in json_chain test was bad, moving the test to
verification, the test is running in `verify_header_param`.
Note that test was previously only for ethash, and now for any engine.

* Restore old behavior (gas uper limit only for ethash engine), at the
cost of an additional trait method.

* Proper rpc test fix.

* Update tests submodule, add SStore bug tests.

* Fix json issue tabulation.
Update tests submodule to latest master (lot of new sstore tests
passing)

* Switch ethereum/tests to tag 6.0.0-beta.1 (no tests changes from latest
synch).

* Display hex with separator, use indirection instead of clone for copy
types.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@andresilva andresilva andresilva left review comments

@niklasad1 niklasad1 niklasad1 approved these changes

@seunlanlege seunlanlege seunlanlege approved these changes

Assignees
No one assigned
Labels
A8-looksgood 🦄 Pull request is reviewed well. B0-patch-stable 🕷 Pull request should also be back-ported to the stable branch. M1-ci 🙉 Continuous integration.
Projects
None yet
Milestone
2.3
Development

Successfully merging this pull request may close these issues.
4 participants
@5chdn @niklasad1 @andresilva @seunlanlege