This repository was archived by the owner on Nov 6, 2020. It is now read-only.
Move EIP-712 crate back to parity-ethereum #10106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like @seunlanlege signed our Contributor License Agreement. 👍 Many thanks, Parity Technologies CLA Bot |
seunlanlege
added
A2-insubstantial 👶
tomusdrw
reviewed
Dec 27, 2018
| @@ -156,35 +156,22 @@ | |||
| //! } | |||
| //! ``` | |||
|
|
|||
| #![warn(missing_docs, unused_extern_crates)] | |||
| #![warn(missing_docs)] | |||
There was a problem hiding this comment.
Why remove unused_extern_crates?
There was a problem hiding this comment.
this module uses rust 2018, no need for extern crates
tomusdrw
reviewed
Dec 27, 2018
seunlanlege
force-pushed
the
eip712-crate
branch
from
701315f to
0d915a6
Compare
sorpaas
approved these changes
Dec 28, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
converted to rust 2018 module, added readme, license