Get connection ID in rpc handler

[xlc]

So that it is possible to rate limit message per seconds per connection

[bkchr]

@niklasad1 AFAIU @xlc would like to contribute some features like this one, can you make sure he gets the help that he needs?

[niklasad1]

Like I said before the RPC handler is not exposed by this library by design.

#918 would solve this issue as well as some similar issues raised recently.

[xlc]

I am not 100% following. How is TwoerService going to help?

All I need is to make this NOT ignore the connect id parameter

jsonrpsee/core/src/server/rpc_module.rs

Line 669 in 18ee212

MethodCallback::new_async(Arc::new(move |id, params, _, max_response_size| {

It could be a simple change by adjusting the callback function signature to include connection ID, which will be a breaking change. Or add new register method with callback takes connection ID.

[xlc]

I am not very familiar with Tower middleware but I don't think it applies here. It is not compatible with websocket frame data.

[niklasad1]

It could be a simple change by adjusting the callback function signature to include connection ID, which will be a breaking change.

Ok, I see that could work.

Or add new register method with callback takes connection ID.

This won't work because register_method is done at initialization i.e, before the connection is established.

I am not very familiar with Tower middleware but I don't think it applies here. It is not compatible with websocket frame data.

Ok, I will write down a better issue for it but yeah you are correct after the HTTP upgrade is completed. Then we have no use of tower but you could actually fetch the connection ID there and store somewhere/spawn a task in your proxy for each connection.
Not sure, I haven't really looked at your code.

To elaborate it would useful if you could add an example snippet code what you want to do then it we would understand better and could help out better.

[xlc]

I am thinking interface similar to subscription. Have a sink or a connection object as a parameter to the callback that allow me to retrieve the connection ID & related details and close the connection.

The goal is to implement rate limiting feature on RPC methods so I am happy with whatever mechanism that achieves it.