You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Nov 11, 2022. It is now read-only.
So this obviously works for now, but what if the client is not fully in sync with the network? I think we need a bit more sophisticated mechanism, where we actually update the validator set id when new blocks are imported / we get synced up.
Currently the BeefyWorker validator set id is always initialized by using BeefyApi::validator_set(). This assumes the client is synced with the network and that the beefy_pallet session handler has seen all relevant on_new_sesseion() calls.
As per the above comment, this approach is not sufficient for an out-of-sync client.
The text was updated successfully, but these errors were encountered:
Related #183
We need to be notified by the block import pipeline about already seen justifications and defer starting the gadget when major sync is on-going.
The issue description is a bit outdated so I will provide an update here.
With Lean BEEFY a node coming online at session N doesn't currently have a way to sync older mandatory BEEFY blocks to get the uninterrupted authority hand-offs chain. Instead, when mandatory block N is BEEFY-finalized, it assumes the finalizing super-majority of validators is honest. The node starts voting in session N+1 based on the finalized mandatory BEEFY block N authority set hand-off.
This issue tracks a way for the node to start voting - in lean beefy just wait for gossip of some mandatory block justification, then start voting on next session based on it - which is implemented.
Support for having the node able to vote as soon as sync is done is tracked in #183
From #95
Currently the
BeefyWorker
validator set id is always initialized by usingBeefyApi::validator_set()
. This assumes the client is synced with the network and that thebeefy_pallet
session handler has seen all relevanton_new_sesseion()
calls.As per the above comment, this approach is not sufficient for an out-of-sync client.
The text was updated successfully, but these errors were encountered: