Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

COMMIT messages and skipping ahead rounds #19

Closed
rphmeier opened this issue Oct 26, 2018 · 1 comment
Closed

COMMIT messages and skipping ahead rounds #19

rphmeier opened this issue Oct 26, 2018 · 1 comment
Assignees
Labels

Comments

@rphmeier
Copy link
Contributor

A safe protocol for skipping ahead in rounds in a voter would be useful. Perhaps it can be done outside, but with a utility provided by this crate.

COMMIT messages need to be fleshed out for observers to more easily witness finality.

@rphmeier
Copy link
Contributor Author

rphmeier commented Nov 16, 2018

About skipping ahead in rounds:

We need logic in VotingRound for not voting when last_round_estimate is None.

The voter keeps an active_round: VotingRound and a prospective_skip: Option<VotingRound>;

Whenever we see a commit for round r > active_round.round + 1, we start prospective_skip at r+1 with no last_round_estimate.

Then one of three things will happen:

  • We see an even further commit and overwrite prospective_skip
  • active_round works its way up to r and becomes completable. In this case, we background active_round, set active_round = prospective_skip.take() and set the new active_round.last_round_estimate accordingly.
  • prospective_skip becomes completable, and we background it and start active_round at r+2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants