Misc fixes to texts #1590
Merged
Misc fixes to texts #1590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmichi
commented
Apr 12, 2024
| /// | ||
| /// This only adds extra ink! linting checks. Basic clippy and ink! lints which we | ||
| /// are deem important are run anyways. | ||
| /// Basic clippy lints are deemed important and run anyways. |
There was a problem hiding this comment.
I would also skip the clippy lints by default, we can do that in a follow-up. Makes it way easier to understand what build --lint does.
cmichi
commented
Apr 12, 2024
| A third party won't be able to confirm that your uploaded contract Wasm blob \ | ||
| matches a particular contract source code.\n\n\ | ||
| You can use `cargo contract build --verifiable` to make the contract verifiable.\n\ | ||
| See https://use.ink/basics/contract-verification for more info.", |
There was a problem hiding this comment.
I'm about to change ink-docs so that this URI will work.
cmichi
commented
Apr 12, 2024
| @@ -369,12 +371,13 @@ where | |||
|
|
|||
| /// Prompt the user to confirm the upload of unverifiable code to the production chain. | |||
| pub fn prompt_confirm_unverifiable_upload(chain: &str) -> Result<()> { | |||
| println!( | |||
| "{} (skip with --skip-validate)", | |||
There was a problem hiding this comment.
I'll create a patch release as a follow-up, --skip-validate does not exist.
ascjones
approved these changes
Apr 12, 2024
crates/cargo-contract/src/cmd/mod.rs
Outdated
| @@ -148,6 +148,8 @@ pub struct CLIChainOpts { | |||
| #[clap(name = "config", long, default_value = "Polkadot")] | |||
| config: String, | |||
| /// Name of a production chain to be communicated with. | |||
| /// | |||
| /// Available: AlephZero, Astar, Shiden, Krest. | |||
There was a problem hiding this comment.
Can we somehow leverage https://docs.rs/clap/latest/clap/trait.ValueEnum.html to show the options, so we don't have to update this comment? Chances are this comment will become out of date when chains added/removed.
There was a problem hiding this comment.
Thanks, that was a good hint. I updated the PR.
smiasojed
approved these changes
Apr 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How the warning looks now: