Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ink! requirements to 4.2.0 #1084

Merged
merged 1 commit into from
Apr 24, 2023
Merged

Update ink! requirements to 4.2.0 #1084

merged 1 commit into from
Apr 24, 2023

Conversation

ascjones
Copy link
Collaborator

No description provided.

Copy link
Contributor

@athei athei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we provide much value by bumping this on every minor. Since new projects will go to the newest minor automatically anyways. So we could just set it to "4" and save us some chores.

@ascjones
Copy link
Collaborator Author

I wonder if we provide much value by bumping this on every minor. Since new projects will go to the newest minor automatically anyways. So we could just set it to "4" and save us some chores.

It is not always necessary, but in this case I believe it might be since it includes some metadata additions e.g. use-ink/ink#1741. So in this case e.g. we want to guarantee that the minimum version is 4.2 so that it includes those changes. It might be possible if another dependency has "=4.0 for ink then it could pull in an older version still.

@ascjones ascjones merged commit 194d0c5 into master Apr 24, 2023
@ascjones ascjones deleted the aj/update-ink-deps branch April 24, 2023 08:40
@ascjones ascjones mentioned this pull request Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants