From b4f2f8b57f9a685cf38b158b07357dcb4f6bf449 Mon Sep 17 00:00:00 2001 From: Devon Govett Date: Mon, 17 Dec 2018 15:45:03 -0800 Subject: [PATCH 1/2] Fix server when there is a dot in the path Fixes #1684. --- packages/core/parcel-bundler/src/Server.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/core/parcel-bundler/src/Server.js b/packages/core/parcel-bundler/src/Server.js index 88702d287a0..dfe81f892fc 100644 --- a/packages/core/parcel-bundler/src/Server.js +++ b/packages/core/parcel-bundler/src/Server.js @@ -63,7 +63,7 @@ function middleware(bundler) { } else { // Otherwise, serve the file from the dist folder req.url = pathname.slice(bundler.options.publicURL.length); - return serve(req, res, send404); + return serve(req, res, sendIndex); } } From e6ad266411b2bfeedaa345ae6adf1e3949750178 Mon Sep 17 00:00:00 2001 From: Devon Govett Date: Mon, 17 Dec 2018 15:51:36 -0800 Subject: [PATCH 2/2] Add test --- packages/core/integration-tests/test/server.js | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/packages/core/integration-tests/test/server.js b/packages/core/integration-tests/test/server.js index b385ba6b31d..9dccf7ca8be 100644 --- a/packages/core/integration-tests/test/server.js +++ b/packages/core/integration-tests/test/server.js @@ -217,6 +217,19 @@ describe('server', function() { ); }); + it('should work with paths that contain a dot', async function() { + let b = bundler(path.join(__dirname, '/integration/html/index.html'), { + publicUrl: '/' + }); + server = await b.serve(0); + + let data = await get('/bar.baz'); + assert.equal( + data, + await fs.readFile(path.join(__dirname, '/dist/index.html'), 'utf8') + ); + }); + it('should not log dev server access for log level <= 3', async function() { let b = bundler(path.join(__dirname, '/integration/html/index.html'), { publicUrl: '/'