Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speed up test_tcp_port_node_record_discovery test #9001

Closed
Rjected opened this issue Jun 20, 2024 · 2 comments
Closed

Speed up test_tcp_port_node_record_discovery test #9001

Rjected opened this issue Jun 20, 2024 · 2 comments
Labels
C-enhancement New feature or request C-test A change that impacts how or what we test D-good-first-issue Nice and easy! A great choice to get started S-stale This issue/PR is stale and will close with no further activity

Comments

@Rjected
Copy link
Member

Rjected commented Jun 20, 2024

For example in this CI run, test_tcp_port_node_record_discovery took a lot of time:
https://github.com/paradigmxyz/reth/actions/runs/9603455329/job/26486706883?pr=8968

        PASS [   0.159s] reth-transaction-pool::it evict::only_blobs_eviction
        PASS [  10.437s] reth-node-ethereum::e2e p2p::can_sync
  TRY 1 SLOW [> 30.000s] reth-network::it startup::test_tcp_port_node_record_discovery
  TRY 1 SLOW [> 60.000s] reth-network::it startup::test_tcp_port_node_record_discovery
  TRY 1 SLOW [> 90.000s] reth-network::it startup::test_tcp_port_node_record_discovery
TRY 1 TRMNTG [>120.000s] reth-network::it startup::test_tcp_port_node_record_discovery
   TRY 1 TMT [ 120.006s] reth-network::it startup::test_tcp_port_node_record_discovery
--- TRY 1 STDOUT:        reth-network::it startup::test_tcp_port_node_record_discovery ---
running 1 test
test startup::test_tcp_port_node_record_discovery has been running for over 60 seconds

   DELAY 2/3 by   1.699s reth-network::it startup::test_tcp_port_node_record_discovery
   RETRY 2/3 [         ] reth-network::it startup::test_tcp_port_node_record_discovery
  TRY 2 SLOW [> 30.000s] reth-network::it startup::test_tcp_port_node_record_discovery
  TRY 2 SLOW [> 60.000s] reth-network::it startup::test_tcp_port_node_record_discovery
  TRY 2 SLOW [> 90.000s] reth-network::it startup::test_tcp_port_node_record_discovery
TRY 2 TRMNTG [>120.000s] reth-network::it startup::test_tcp_port_node_record_discovery
   TRY 2 TMT [ 120.007s] reth-network::it startup::test_tcp_port_node_record_discovery
--- TRY 2 STDOUT:        reth-network::it startup::test_tcp_port_node_record_discovery ---
running 1 test
test startup::test_tcp_port_node_record_discovery has been running for over 60 seconds

   DELAY 3/3 by   3.361s reth-network::it startup::test_tcp_port_node_record_discovery
   RETRY 3/3 [         ] reth-network::it startup::test_tcp_port_node_record_discovery
  TRY 3 SLOW [> 30.000s] reth-network::it startup::test_tcp_port_node_record_discovery
  TRY 3 SLOW [> 60.000s] reth-network::it startup::test_tcp_port_node_record_discovery
  TRY 3 SLOW [> 90.000s] reth-network::it startup::test_tcp_port_node_record_discovery
TRY 3 TRMNTG [>120.000s] reth-network::it startup::test_tcp_port_node_record_discovery
   TRY 3 TMT [ 120.010s] reth-network::it startup::test_tcp_port_node_record_discovery
--- TRY 3 STDOUT:        reth-network::it startup::test_tcp_port_node_record_discovery ---
running 1 test
test startup::test_tcp_port_node_record_discovery has been running for over 60 seconds

   Canceling due to test failure
------------
     Summary [ 377.896s] 148 tests run: 147 passed, 1 timed out, 10 skipped
   TRY 3 TMT [ 120.010s] reth-network::it startup::test_tcp_port_node_record_discovery

This test should be fixed to not stall

@Rjected Rjected added C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started C-test A change that impacts how or what we test labels Jun 20, 2024
@mattsse
Copy link
Collaborator

mattsse commented Jun 20, 2024

hmm this is odd, can't reproduce locally, but perhaps this has something to do with the discovery part here

Copy link
Contributor

This issue is stale because it has been open for 21 days with no activity.

@github-actions github-actions bot added the S-stale This issue/PR is stale and will close with no further activity label Jul 12, 2024
@mattsse mattsse closed this as completed Jul 12, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in Reth Tracker Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement New feature or request C-test A change that impacts how or what we test D-good-first-issue Nice and easy! A great choice to get started S-stale This issue/PR is stale and will close with no further activity
Projects
Archived in project
Development

No branches or pull requests

2 participants