Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Hash Builder as a fallback to the Sparse Trie on newPayload #14166

Closed
Tracked by #11169
shekhirin opened this issue Feb 3, 2025 · 1 comment · Fixed by #14387
Closed
Tracked by #11169

Use Hash Builder as a fallback to the Sparse Trie on newPayload #14166

shekhirin opened this issue Feb 3, 2025 · 1 comment · Fixed by #14387
Assignees
@fgimenez
Labels
A-trie Related to Merkle Patricia Trie implementation C-enhancement New feature or request
Milestone
Release 1.2.0

Comments

@shekhirin
Copy link
Collaborator

Describe the feature

Soon we'll be ready to remove the optional --engine.state-root-task and use the State Root Task by default. But before that, we need to enable the old Hash Builder state root implementation as a fallback in cases when the State Root Task returns a state root mismatching with the header.

Additional context

No response
@shekhirin shekhirin added A-trie Related to Merkle Patricia Trie implementation C-enhancement New feature or request labels Feb 3, 2025
@shekhirin shekhirin self-assigned this Feb 3, 2025
This was referenced Feb 3, 2025
Open
Closed
@nadtech-hub
Copy link
Contributor

✋

@shekhirin shekhirin mentioned this issue Feb 10, 2025
Merged
@fgimenez fgimenez assigned fgimenez and unassigned shekhirin Feb 10, 2025
@fgimenez fgimenez moved this from Todo to In Progress in Reth Tracker Feb 10, 2025
@fgimenez fgimenez mentioned this issue Feb 10, 2025
Merged
@jenpaff jenpaff added this to the Release 1.2.0 milestone Feb 11, 2025
@github-project-automation github-project-automation bot moved this from In Progress to Done in Reth Tracker Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fgimenez fgimenez

Labels
A-trie Related to Merkle Patricia Trie implementation C-enhancement New feature or request
Projects
Reth Tracker
Status: Done
Milestone
Release 1.2.0
Development

Successfully merging a pull request may close this issue.

feat(engine): use Hash Builder as a fallback to the Sparse Trie on newPayload paradigmxyz/reth
4 participants
@fgimenez @jenpaff @shekhirin @nadtech-hub