Skip to content

Commit bebd5db

Browse files
committed
Remove TODOs and = version pinning
1 parent f396d0d commit bebd5db

File tree

16 files changed

+21
-41
lines changed

16 files changed

+21
-41
lines changed

src/rust/engine/Cargo.toml

+1-2
Original file line numberDiff line numberDiff line change
@@ -125,8 +125,7 @@ store = { path = "fs/store" }
125125
task_executor = { path = "task_executor" }
126126
tempfile = "3"
127127
time = "0.1.40"
128-
# TODO: See #10291.
129-
tokio = { version = "=0.2.22", features = ["rt-threaded"] }
128+
tokio = { version = "0.2.22", features = ["rt-threaded"] }
130129
ui = { path = "ui" }
131130
url = "2.1"
132131
uuid = { version = "0.7", features = ["v4"] }

src/rust/engine/async_semaphore/Cargo.toml

+2-4
Original file line numberDiff line numberDiff line change
@@ -7,10 +7,8 @@ publish = false
77

88
[dependencies]
99
parking_lot = "0.11"
10-
# TODO: See #10291.
11-
tokio = { version = "=0.2.22", features = ["sync"] }
10+
tokio = { version = "0.2.22", features = ["sync"] }
1211

1312
[dev-dependencies]
1413
futures = "0.3"
15-
# TODO: See #10291.
16-
tokio = { version = "=0.2.22", features = ["rt-core", "macros", "time"] }
14+
tokio = { version = "0.2.22", features = ["rt-core", "macros", "time"] }

src/rust/engine/fs/Cargo.toml

+1-2
Original file line numberDiff line numberDiff line change
@@ -21,5 +21,4 @@ task_executor = { path = "../task_executor" }
2121
[dev-dependencies]
2222
tempfile = "3"
2323
testutil = { path = "../testutil" }
24-
# TODO: See #10291.
25-
tokio = { version = "=0.2.22", features = ["rt-core", "macros"] }
24+
tokio = { version = "0.2.22", features = ["rt-core", "macros"] }

src/rust/engine/fs/brfs/Cargo.toml

+1-2
Original file line numberDiff line numberDiff line change
@@ -22,8 +22,7 @@ serverset = { path = "../../serverset" }
2222
store = { path = "../store" }
2323
task_executor = { path = "../../task_executor" }
2424
time = "0.1.39"
25-
# TODO: See #10291.
26-
tokio = { version = "=0.2.22", features = ["rt-threaded", "macros", "signal", "stream"] }
25+
tokio = { version = "0.2.22", features = ["rt-threaded", "macros", "signal", "stream"] }
2726
workunit_store = { path = "../../workunit_store" }
2827

2928
[dev-dependencies]

src/rust/engine/fs/fs_util/Cargo.toml

+1-2
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,5 @@ serde_json = "1.0"
2222
serde_derive = "1.0"
2323
store = { path = "../store" }
2424
task_executor = { path = "../../task_executor" }
25-
# TODO: See #10291.
26-
tokio = { version = "=0.2.22", features = ["rt-threaded", "macros"] }
25+
tokio = { version = "0.2.22", features = ["rt-threaded", "macros"] }
2726
workunit_store = { path = "../../workunit_store" }

src/rust/engine/fs/store/Cargo.toml

+1-2
Original file line numberDiff line numberDiff line change
@@ -36,8 +36,7 @@ workunit_store = {path = "../../workunit_store" }
3636
maplit = "*"
3737
mock = { path = "../../testutil/mock" }
3838
testutil = { path = "../../testutil" }
39-
# TODO: See #10291.
40-
tokio = { version = "=0.2.22", features = ["rt-core", "macros"] }
39+
tokio = { version = "0.2.22", features = ["rt-core", "macros"] }
4140
walkdir = "2"
4241
criterion = "0.3"
4342

src/rust/engine/graph/Cargo.toml

+2-4
Original file line numberDiff line numberDiff line change
@@ -12,11 +12,9 @@ futures = "0.3"
1212
log = "0.4"
1313
parking_lot = "0.11"
1414
petgraph = "0.4.5"
15-
# TODO: See #10291.
16-
tokio = { version = "=0.2.22", features = ["time"] }
15+
tokio = { version = "0.2.22", features = ["time"] }
1716

1817
[dev-dependencies]
1918
rand = "0.6"
2019
env_logger = "0.5.4"
21-
# TODO: See #10291.
22-
tokio = { version = "=0.2.22", features = ["macros", "rt-threaded", "time"] }
20+
tokio = { version = "0.2.22", features = ["macros", "rt-threaded", "time"] }

src/rust/engine/logging/Cargo.toml

+1-1
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ lazy_static = "1"
1212
log = "0.4"
1313
num_enum = "0.4"
1414
parking_lot = "0.11"
15-
tokio = { version = "=0.2.22", features = ["rt-util"] } # TODO: see https://github.com/pantsbuild/pants/issues/10291
15+
tokio = { version = "0.2.22", features = ["rt-util"] }
1616
uuid = { version = "0.7", features = ["v4"] }
1717

1818
[build-dependencies]

src/rust/engine/nailgun/Cargo.toml

+2-4
Original file line numberDiff line numberDiff line change
@@ -12,9 +12,7 @@ log = "0.4"
1212
nails = "0.6.0"
1313
os_pipe = "0.9"
1414
task_executor = { path = "../task_executor" }
15-
# TODO: See #10291.
16-
tokio = { version = "=0.2.22", features = ["tcp", "fs", "sync"] }
15+
tokio = { version = "0.2.22", features = ["tcp", "fs", "sync"] }
1716

1817
[dev-dependencies]
19-
# TODO: See #10291.
20-
tokio = { version = "=0.2.22", features = ["dns", "rt-threaded", "macros"] }
18+
tokio = { version = "0.2.22", features = ["dns", "rt-threaded", "macros"] }

src/rust/engine/process_execution/Cargo.toml

+2-4
Original file line numberDiff line numberDiff line change
@@ -30,8 +30,7 @@ store = { path = "../fs/store" }
3030
task_executor = { path = "../task_executor" }
3131
tempfile = "3"
3232
concrete_time = { path = "../concrete_time" }
33-
# TODO: See #10291.
34-
tokio = { version = "=0.2.22", features = ["process", "rt-threaded", "sync", "tcp", "time"] }
33+
tokio = { version = "0.2.22", features = ["process", "rt-threaded", "sync", "tcp", "time"] }
3534
tokio-util = { version = "0.2", features = ["codec"] }
3635
uname = "0.1.1"
3736
workunit_store = { path = "../workunit_store" }
@@ -51,5 +50,4 @@ parking_lot = "0.11"
5150
spectral = "0.6.0"
5251
tempfile = "3"
5352
testutil = { path = "../testutil" }
54-
# TODO: See #10291.
55-
tokio = { version = "=0.2.22", features = ["macros"] }
53+
tokio = { version = "0.2.22", features = ["macros"] }

src/rust/engine/process_executor/Cargo.toml

+1-2
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,5 @@ log = "0.4"
1616
process_execution = { path = "../process_execution" }
1717
store = { path = "../fs/store" }
1818
task_executor = { path = "../task_executor" }
19-
# TODO: See #10291.
20-
tokio = { version = "=0.2.22", features = ["rt-threaded", "macros"] }
19+
tokio = { version = "0.2.22", features = ["rt-threaded", "macros"] }
2120
workunit_store = { path = "../workunit_store"}

src/rust/engine/serverset/Cargo.toml

+2-4
Original file line numberDiff line numberDiff line change
@@ -8,11 +8,9 @@ publish = false
88
[dependencies]
99
futures = "0.3"
1010
parking_lot = "0.11"
11-
# TODO: See #10291.
12-
tokio = { version = "=0.2.22", features = ["time"] }
11+
tokio = { version = "0.2.22", features = ["time"] }
1312

1413
[dev-dependencies]
1514
maplit = "1"
1615
testutil = { path = "../testutil" }
17-
# TODO: See #10291.
18-
tokio = { version = "=0.2.22", features = ["rt-core", "macros"] }
16+
tokio = { version = "0.2.22", features = ["rt-core", "macros"] }

src/rust/engine/task_executor/Cargo.toml

+1-2
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,5 @@ publish = false
99
futures = "0.3"
1010
logging = { path = "../logging" }
1111
num_cpus = "1"
12-
# TODO: See #10291.
13-
tokio = { version = "=0.2.22", features = ["blocking", "rt-threaded"] }
12+
tokio = { version = "0.2.22", features = ["blocking", "rt-threaded"] }
1413
workunit_store = { path = "../workunit_store" }

src/rust/engine/testutil/mock/Cargo.toml

+1-2
Original file line numberDiff line numberDiff line change
@@ -16,5 +16,4 @@ hashing = { path = "../../hashing" }
1616
parking_lot = "0.11"
1717
protobuf = { version = "2.0.6", features = ["with-bytes"] }
1818
testutil = { path = ".." }
19-
# TODO: See #10291.
20-
tokio = { version = "=0.2.22", features = ["time"] }
19+
tokio = { version = "0.2.22", features = ["time"] }

src/rust/engine/watch/Cargo.toml

+1-2
Original file line numberDiff line numberDiff line change
@@ -20,5 +20,4 @@ task_executor = { path = "../task_executor" }
2020
[dev-dependencies]
2121
tempfile = "3"
2222
testutil = { path = "../testutil" }
23-
# TODO: See #10291.
24-
tokio = { version = "=0.2.22", features = ["rt-core", "macros"] }
23+
tokio = { version = "0.2.22", features = ["rt-core", "macros"] }

src/rust/engine/workunit_store/Cargo.toml

+1-2
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@ concrete_time = { path = "../concrete_time" }
1010
hashing = { path = "../hashing" }
1111
parking_lot = "0.11"
1212
rand = "0.6"
13-
# TODO: See #10291.
14-
tokio = { version = "=0.2.22", features = ["rt-util"] }
13+
tokio = { version = "0.2.22", features = ["rt-util"] }
1514
petgraph = "0.4.5"
1615
log = "0.4"

0 commit comments

Comments
 (0)