Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Incorrect Comment in ants.go Regarding workerChanCap Description #346

Closed
AlvinZGH opened this issue Dec 11, 2024 · 1 comment
Closed
Assignees
Labels
enhancement New feature or request proposal Proposal for this repo

Comments

@AlvinZGH
Copy link

Description of new feature

Due to the recent version update of fasthttp, the original line numbers no longer correspond to the line numbers for workerChanCap.
fasthttp

Scenarios for new feature

Current Text: [https://github.com/valyala/fasthttp/blob/master/workerpool.go#L139]
Suggested Correction: [https://github.com/valyala/fasthttp/blob/v1.58.0/workerpool.go#L158]
Reason for Change: [I believe this change will improve the documentation more accurate]

Breaking changes or not?

No

Code snippets (optional)

No response

Alternatives for new feature

No response

Additional context (optional)

No response

@AlvinZGH AlvinZGH added enhancement New feature or request proposal Proposal for this repo labels Dec 11, 2024
@panjf2000
Copy link
Owner

Actually, I don't think we need this comment anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request proposal Proposal for this repo
Projects
None yet
Development

No branches or pull requests

2 participants