Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto backport of pr 25701 on 0.24.x #25713

Conversation

WillAyd
Copy link
Member

@WillAyd WillAyd commented Mar 13, 2019

@TomAugspurger @jorisvandenbossche @jreback want to double check I did this right. I didn't use the -m flag during the cherry-pick process as that was causing failures

0.24.3 at this point?

@jorisvandenbossche jorisvandenbossche changed the base branch from master to 0.24.x March 13, 2019 17:26
@jorisvandenbossche
Copy link
Member

@WillAyd what was wrong is that the PR was not targetting the 0.24.x branch but master (I changed it now, but before it was showing a huge number of commits).
So when you crate a PR, you can choose which branch you want to merge it in. Or after creating, if you do the "Edit" button next to the title, you can still change it.

But so now with targetting 0.24.x branch, this looks fine.

I typically use git cherry-pick -x <sha>

@jorisvandenbossche jorisvandenbossche added this to the 0.24.3 milestone Mar 13, 2019
@WillAyd
Copy link
Member Author

WillAyd commented Mar 13, 2019

@jorisvandenbossche thanks yea that did look off so thanks for fixing and clarifying.

@jreback jreback added the CI Continuous Integration label Mar 14, 2019
@jreback
Copy link
Contributor

jreback commented Mar 18, 2019

@WillAyd this should be merged or closed?

@WillAyd
Copy link
Member Author

WillAyd commented Mar 18, 2019

@jreback I think OK to merge

@jorisvandenbossche jorisvandenbossche merged commit 95938db into pandas-dev:0.24.x Mar 18, 2019
@jorisvandenbossche
Copy link
Member

Thanks!

@WillAyd WillAyd deleted the auto-backport-of-pr-25701-on-0.24.x branch January 16, 2020 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants