Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLN: blocks, not series, should contain logic for arithmetic #9859

Closed
shoyer opened this issue Apr 11, 2015 · 6 comments
Closed

CLN: blocks, not series, should contain logic for arithmetic #9859

shoyer opened this issue Apr 11, 2015 · 6 comments
Labels
Internals Related to non-user accessible pandas implementation

Comments

@shoyer
Copy link
Member

shoyer commented Apr 11, 2015

See discussion here: #9848 (comment)

This would likely help clean up some of the Series/DataFrame discrepancies in arithmetic operations (mostly for datetime types).

@shoyer shoyer added Internals Related to non-user accessible pandas implementation Difficulty Advanced labels Apr 11, 2015
@jreback jreback added this to the Next Major Release milestone Apr 12, 2015
@max-sixty
Copy link
Contributor

Would this also help performance materially, if DataFrame ops could iterate over Blocks rather than Columns?
ref #11623, #11618

@jreback
Copy link
Contributor

jreback commented Nov 17, 2015

@MaximilianR most things are already dispatched already by blocks.

@max-sixty
Copy link
Contributor

Ah, fair, cheers. The ones that are applied across columns (which happen to have been the ones I've been using recently), seem to only be quantile & round.
(There are others on the DataFrame object such as rank, but don't iterate over columns in python)

@jreback
Copy link
Contributor

jreback commented Nov 17, 2015

yeh round is almost a display thing so doesn't really count (and could be daily broadcast)

quantile is bad impl ATM

@max-sixty
Copy link
Contributor

I could do a PR for quantile if it's not too complex - what should that look like? Could it go straight to np.nanpercentile [link]?
Looking at the current code, it's doing a lot though.

@jbrockmendel
Copy link
Member

@jreback closeable? We’ve recently finished getting all arithmetic out of blocks.

@jreback jreback closed this as completed Oct 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Internals Related to non-user accessible pandas implementation
Projects
None yet
Development

No branches or pull requests

4 participants