Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SQL: test with oldest supported sqlalchemy #9087

Closed
jorisvandenbossche opened this issue Dec 15, 2014 · 2 comments
Closed

SQL: test with oldest supported sqlalchemy #9087

jorisvandenbossche opened this issue Dec 15, 2014 · 2 comments
Labels
IO SQL to_sql, read_sql, read_sql_query Testing pandas testing functions or related to the test suite

Comments

@jorisvandenbossche
Copy link
Member

Noticed when looking at #9083 that we used an sqlalchemy feature in #8926 that is not supported in at least sqlalchemy

Concrete, it is about import sqlalchemy.sql.type_api as type_api (https://github.com/pydata/pandas/blob/v0.15.2/pandas/io/sql.py#L1162). I cannot import this 0.8.2 (and in any case, this should better be sqlalchemy.types.TypeEngine instead of type_api.TypeEngine)

We should check if we test older slqalchemy versions (0.8.x series, or even 0.7.x series?), or why this has not been caught by the tests.

@jorisvandenbossche jorisvandenbossche added IO SQL to_sql, read_sql, read_sql_query Testing pandas testing functions or related to the test suite labels Dec 15, 2014
@jorisvandenbossche jorisvandenbossche added this to the 0.16.0 milestone Dec 15, 2014
@jreback jreback modified the milestones: 0.16.0, Next Major Release Mar 6, 2015
@jbrockmendel
Copy link
Member

@datapythonista i know you've been looking at the dependencies in the CI. is this feasible?

@datapythonista
Copy link
Member

I'll make a proposal soon for #29685, which should fix this sort of problems.

But this issue is 5 years old, I assume this is not a problem anymore. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
IO SQL to_sql, read_sql, read_sql_query Testing pandas testing functions or related to the test suite
Projects
None yet
Development

No branches or pull requests

4 participants