Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BLD: remove pkg_resources usage from setup.py #53384

Open
fangchenli opened this issue May 25, 2023 · 0 comments
Open

BLD: remove pkg_resources usage from setup.py #53384

fangchenli opened this issue May 25, 2023 · 0 comments
Labels
Build Library building on various platforms

Comments

@fangchenli
Copy link
Member

pkg_resources is deprecated and needs to be removed.

After #49115, version checks in setup.py are unnecessary. And MACOSX_DEPLOYMENT_TARGET should be set in meson script instead of setup.py.

Maybe bump MACOSX_DEPLOYMENT_TARGET as well?
@fangchenli fangchenli added the Build Library building on various platforms label May 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Build Library building on various platforms
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@fangchenli