Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RLS: 1.1.5 #38066

Closed
simonjayhawkins opened this issue Nov 25, 2020 · 19 comments
Closed

RLS: 1.1.5 #38066

simonjayhawkins opened this issue Nov 25, 2020 · 19 comments
Labels
Milestone

Comments

@simonjayhawkins
Copy link
Member

Tracking issue for the 1.1.5 release.

https://github.com/pandas-dev/pandas/milestone/79

@simonjayhawkins simonjayhawkins added this to the 1.1.5 milestone Nov 25, 2020
@simonjayhawkins
Copy link
Member Author

simonjayhawkins commented Nov 25, 2020

Currently scheduled for November 30, 2020, date may change depending on discussions about 1.2.0rc0 release. see #37784

@simonjayhawkins
Copy link
Member Author

simonjayhawkins commented Nov 25, 2020

There are currently no blockers here and wheels are building so could release anytime.

There are a number of open issues that are currently milestoned 1.1.5 that intereted parties should be aware that have not been addressed and therefore the release should imo not be before November 30, 2020 to give people a chance to comment.

see #37784 (comment)

@simonjayhawkins
Copy link
Member Author

@jorisvandenbossche following discussion in #37784 (comment)

proposed comment for the open issues...

This issue is milestoned 1.1.5. This issue has not yet been addressed and the 1.1.5 release is scheduled for Monday, November 30, 2020. The 1.2 release candidate is also imminent. The milestone is therefore being moved to 1.2.1. Contributions from the community are always welcome and PRs opened before the release of 1.1.5 may still be reviewed and merged in time to be included in v1.1.5.

@simonjayhawkins
Copy link
Member Author

During the 1.1.x releases, I requested others (and did myself) to tag issues that were regressions from 1.0.5 with the next 1.1.x milestone.

Now that we approach the end of the 1.1.x series of releases, I'd be interested on other's views on this process and whether to do the same for 1.2.x.

I think that it provided better tracking/visibility for those issues. The downside is that without allocating the issues to individuals some issues were moved from milestone to milestone.

As @jorisvandenbossche mentioned in #37784 (comment)

we do potentially have some support for maintenance, and fixing release blockers can be part of that.

maybe we can extend that to regressions in general (and track using the regression label and not the milestone label)

Moving from milestone to milestone may be seen as unprofessional, so I propose that we don't add the milestones to the issues for future reported regressions unless we have someone allocated to fix.

@pandas-dev/pandas-core

@jreback
Copy link
Contributor

jreback commented Nov 27, 2020

Moving from milestone to milestone may be seen as unprofessional, so I propose that we don't add the milestones to the issues for future reported regressions unless we have someone allocated to fix

it is impossible to fix everything w/o dedicated and paid resources

we do the best we can and it is what it is

we release pretty frequently and we do a good job

the worst thing we could do is delay releases to make sure 'everything is fixed' that would mean we essentially never release

regressions on a project this size can and do happen

@jreback
Copy link
Contributor

jreback commented Dec 1, 2020

@simonjayhawkins I think go for release here (if you want to merge the cython PR go for it, ok not to as well)

@simonjayhawkins
Copy link
Member Author

simonjayhawkins commented Dec 2, 2020

see #37784 (comment) and #37784 (comment)

Unless our goal is to actually fix them. IMO we should take the time to go through the remaining issues, identify the important regressions, and actually try to fix them before the release. Even if that delays the release a little bit, IMO that's still a good outcome. We have some support for maintenance now, and fixing release blockers can be part of that IMO.

so continuing to push ahead with the 1.2.0rc0 release as scheduled (and then backporting any regression fixes on master for 1.2.0) and re-scheduling the 1.1.5 release for December 07, 2020 was intended to strike a balance/find some middle ground here.

@jreback
Copy link
Contributor

jreback commented Dec 5, 2020

@simonjayhawkins i would simply release now

@simonjayhawkins
Copy link
Member Author

OK. i'll do this before 1.2.0rc0 for simplicity if they are both being released around the same time.

wheels for Windows 3.6 aren't building (maybe others, test not yet complete) MacPython/pandas-wheels#109

but won't block on these. will open PR to set the release date to today in the 1.1.5 release notes shortly if the others are green.

It's much later in the day here than when I normally start a release, so may not complete process today.

@simonjayhawkins
Copy link
Member Author

wheels for Windows 3.6 aren't building

seems to be in the python setup.py build step, maybe #37732 related

@simonjayhawkins
Copy link
Member Author

locally i'm getting a similar warning

C:\Users\simon\anaconda3\envs\py36\lib\site-packages\setuptools\dist.py:679: UserWarning: Module numpy was already imported from C:\Users\simon\anaconda3\envs\py36\lib\site-packages\numpy\__init__.py, but c:\users\simon\pandas\.eggs\numpy-1.19.4-py3.6-win-amd64.egg is being added to sys.path

but not picking up numpy-1.20.0rc1 so not failing to build with RuntimeError: Python version >= 3.7 required.

@simonjayhawkins
Copy link
Member Author

looks like the issue is fixed by changing NP_BUILD_DEP to 1.15.4

@simonjayhawkins
Copy link
Member Author

simonjayhawkins commented Dec 7, 2020

@simonjayhawkins
Copy link
Member Author

simonjayhawkins commented Dec 7, 2020

pre-release checks passed. starting release now.

@simonjayhawkins
Copy link
Member Author

I need to pop out for an hour. wheels are built. will do the github release when I get back to reduce the lag from the notification generated by creating the github release and wheels being available on PyPI

conda-forge should be automatically picked up after creating the Github release.

@simonjayhawkins
Copy link
Member Author

conda-forge should be automatically picked up after creating the Github release.

conda-forge/pandas-feedstock#100

@simonjayhawkins
Copy link
Member Author

available on conda-forge https://anaconda.org/conda-forge/pandas/files

@jreback
Copy link
Contributor

jreback commented Dec 8, 2020

thanks @simonjayhawkins for the work in the release !

@jorisvandenbossche
Copy link
Member

Thanks a lot @simonjayhawkins !
Do you also sent out an announcement email?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants