-
-
Notifications
You must be signed in to change notification settings - Fork 18.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RLS: 1.1.5 #38066
Comments
Currently scheduled for November 30, 2020, date may change depending on discussions about 1.2.0rc0 release. see #37784 |
There are currently no blockers here and wheels are building so could release anytime. There are a number of open issues that are currently milestoned 1.1.5 that intereted parties should be aware that have not been addressed and therefore the release should imo not be before November 30, 2020 to give people a chance to comment. see #37784 (comment) |
@jorisvandenbossche following discussion in #37784 (comment) proposed comment for the open issues... This issue is milestoned 1.1.5. This issue has not yet been addressed and the 1.1.5 release is scheduled for Monday, November 30, 2020. The 1.2 release candidate is also imminent. The milestone is therefore being moved to 1.2.1. Contributions from the community are always welcome and PRs opened before the release of 1.1.5 may still be reviewed and merged in time to be included in v1.1.5. |
During the 1.1.x releases, I requested others (and did myself) to tag issues that were regressions from 1.0.5 with the next 1.1.x milestone. Now that we approach the end of the 1.1.x series of releases, I'd be interested on other's views on this process and whether to do the same for 1.2.x. I think that it provided better tracking/visibility for those issues. The downside is that without allocating the issues to individuals some issues were moved from milestone to milestone. As @jorisvandenbossche mentioned in #37784 (comment)
maybe we can extend that to regressions in general (and track using the regression label and not the milestone label) Moving from milestone to milestone may be seen as unprofessional, so I propose that we don't add the milestones to the issues for future reported regressions unless we have someone allocated to fix. @pandas-dev/pandas-core |
it is impossible to fix everything w/o dedicated and paid resources we do the best we can and it is what it is we release pretty frequently and we do a good job the worst thing we could do is delay releases to make sure 'everything is fixed' that would mean we essentially never release regressions on a project this size can and do happen |
@simonjayhawkins I think go for release here (if you want to merge the cython PR go for it, ok not to as well) |
see #37784 (comment) and #37784 (comment)
so continuing to push ahead with the 1.2.0rc0 release as scheduled (and then backporting any regression fixes on master for 1.2.0) and re-scheduling the 1.1.5 release for December 07, 2020 was intended to strike a balance/find some middle ground here. |
@simonjayhawkins i would simply release now |
OK. i'll do this before 1.2.0rc0 for simplicity if they are both being released around the same time. wheels for Windows 3.6 aren't building (maybe others, test not yet complete) MacPython/pandas-wheels#109 but won't block on these. will open PR to set the release date to today in the 1.1.5 release notes shortly if the others are green. It's much later in the day here than when I normally start a release, so may not complete process today. |
seems to be in the |
locally i'm getting a similar warning
but not picking up numpy-1.20.0rc1 so not failing to build with |
looks like the issue is fixed by changing NP_BUILD_DEP to 1.15.4 |
final pre-release checklist
|
pre-release checks passed. starting release now.
|
I need to pop out for an hour. wheels are built. will do the github release when I get back to reduce the lag from the notification generated by creating the github release and wheels being available on PyPI conda-forge should be automatically picked up after creating the Github release. |
|
available on conda-forge https://anaconda.org/conda-forge/pandas/files |
thanks @simonjayhawkins for the work in the release ! |
Thanks a lot @simonjayhawkins ! |
Tracking issue for the 1.1.5 release.
https://github.com/pandas-dev/pandas/milestone/79
The text was updated successfully, but these errors were encountered: