Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI/TST: xfail in test_parquet has passed #37067

Closed
fangchenli opened this issue Oct 12, 2020 · 5 comments
Closed

CI/TST: xfail in test_parquet has passed #37067

fangchenli opened this issue Oct 12, 2020 · 5 comments
Assignees
Labels
CI Continuous Integration Testing pandas testing functions or related to the test suite Unreliable Test Unit tests that occasionally fail

Comments

@fangchenli
Copy link
Member

The xfail test test_s3_roundtrip_for_dir in io/test_parquet has passed on my machine. But I don't see it on our CI.

INSTALLED VERSIONS

commit : 4d3b197
python : 3.8.6.final.0
python-bits : 64
OS : Linux
OS-release : 5.4.0-48-generic
Version : #52-Ubuntu SMP Thu Sep 10 10:58:49 UTC 2020
machine : x86_64
processor : x86_64
byteorder : little
LC_ALL : None
LANG : en_US.UTF-8
LOCALE : en_US.UTF-8
pandas : 1.2.0.dev0+745.g4d3b197c9
numpy : 1.19.2
pytz : 2020.1
dateutil : 2.8.1
pip : 20.2.3
setuptools : 49.6.0.post20201009
Cython : 0.29.21
pytest : 6.1.1
hypothesis : 5.37.1
sphinx : 3.2.1
blosc : None
feather : None
xlsxwriter : 1.3.6
lxml.etree : 4.5.2
html5lib : 1.1
pymysql : None
psycopg2 : None
jinja2 : 2.11.2
IPython : 7.18.1
pandas_datareader: None
bs4 : 4.9.3
bottleneck : 1.3.2
fsspec : 0.8.3
fastparquet : 0.4.1
gcsfs : 0.7.1
matplotlib : 3.3.2
numexpr : 2.7.1
odfpy : None
openpyxl : 3.0.5
pandas_gbq : None
pyarrow : 1.0.1
pytables : None
pyxlsb : None
s3fs : 0.4.2
scipy : 1.5.2
sqlalchemy : 1.3.19
tables : 3.6.1
tabulate : 0.8.7
xarray : 0.16.1
xlrd : 1.2.0
xlwt : 1.3.0
numba : 0.51.2

@fangchenli fangchenli added Bug Needs Triage Issue that has not been reviewed by a pandas team member CI Continuous Integration Testing pandas testing functions or related to the test suite and removed Bug Needs Triage Issue that has not been reviewed by a pandas team member labels Oct 12, 2020
@fangchenli fangchenli changed the title BUG: xfail in test_parquet has passed CI/TST: xfail in test_parquet has passed Oct 12, 2020
@dsaxton
Copy link
Member

dsaxton commented Oct 12, 2020

Hmm, this does fail for me locally on either Mac OS or Ubuntu Python3.8.

@fangchenli
Copy link
Member Author

I rebuilt my environment but still see it. Not sure why.

@jbrockmendel jbrockmendel added the Unreliable Test Unit tests that occasionally fail label Oct 28, 2020
@nofarm3
Copy link
Contributor

nofarm3 commented Jan 20, 2021

take

@nofarm3
Copy link
Contributor

nofarm3 commented Jan 21, 2021

@fangchenli Is this issue still relevant? I see test_s3_roundtrip_for_dir marked with @td.skip_if_no("s3fs") and not with @pytest.mark.xfail

@fangchenli
Copy link
Member Author

@fangchenli Is this issue still relevant? I see test_s3_roundtrip_for_dir marked with @td.skip_if_no("s3fs") and not with @pytest.mark.xfail

It's fixed by #38514. But thank you for taking a look at this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration Testing pandas testing functions or related to the test suite Unreliable Test Unit tests that occasionally fail
Projects
None yet
Development

No branches or pull requests

4 participants