Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH: implement efficient sorting methods for SparseArray (argsort/argmin/argmax) #34197

Closed
jorisvandenbossche opened this issue May 15, 2020 · 0 comments · Fixed by #47779
Closed

ENH: implement efficient sorting methods for SparseArray (argsort/argmin/argmax) #34197

jorisvandenbossche opened this issue May 15, 2020 · 0 comments · Fixed by #47779
Labels
Enhancement Performance Memory or execution speed performance Sparse Sparse Data Type

Comments

@jorisvandenbossche
Copy link
Member

xref #27801 (comment)

SparseArray currently does not implement _values_for_argsort or argsort/argmin/argmax` itself, which means it is using the base implementation, which converts the sparse array to a dense numpy array. Room for improvements thus.
@jorisvandenbossche jorisvandenbossche added this to the Contributions Welcome milestone May 15, 2020
@jorisvandenbossche jorisvandenbossche mentioned this issue May 15, 2020
Merged
@jbrockmendel jbrockmendel added the Performance Memory or execution speed performance label Dec 20, 2021
@GYHHAHA GYHHAHA mentioned this issue Jul 18, 2022
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Enhancement Performance Memory or execution speed performance Sparse Sparse Data Type
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

PERF: efficient argmax/argmin for SparseArray GYHHAHA/pandas
2 participants
@jorisvandenbossche @jbrockmendel