DOC/DEPR: sep vs pat in series.str.partition

[h-vetinari]

All the way back to the v0.16 docs, Series.str.partition (https://pandas.pydata.org/pandas-docs/stable/generated/pandas.Series.str.partition.html) has the signature Series.str.partition(pat=' ', expand=True), but the docs only talk about sep instead of pat.

I think the kwarg should be renamed to sep, which makes more sense for partitioning something than pat, which sounds like it's about a regex pattern.

Same thing applies to rpartition.

[artsiomkaltovich]

It is standard method https://docs.python.org/3/library/stdtypes.html#str.partition
The parameter is named sep there, but in Pandas implementation it is pat
https://github.com/pandas-dev/pandas/blob/v0.23.4/pandas/core/strings.py#L2382-L2391

I agree that parameter should be renamed, can I take this one?

[h-vetinari]

@ArtyomKaltovich

I agree that parameter should be renamed, can I take this one?

Sorry for the late reply, no reason you shouldn't tackle it!