-
-
Notifications
You must be signed in to change notification settings - Fork 18.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DEPR: join_axes-kwarg for pd.concat #21951
Comments
Not terribly familiar with this keyword and agreed it seems odd. I'm +1 for deprecating |
cc @jreback |
Some remarks:
It is certainly true the way it is explained and spelled (eg the fact that you need to pass a list) is certainly outdated now Panel is removed. But we could also consider improving it. You can eg now use it to basically do a 'left' join. (note that I am not married to the keyword, I have never used it myself, but just think we should have a bit more discussion about it. It would be interesting to search for usage on github/SO) |
The
join_axes
kwarg ofpd.concat
is not very clearly documented (took me several tries to get it to work), and its name is not very clear either -- it's actually about restricting the axes that are not being concatenated (i.e. would be'outer'
-joined normally).In particular, it is basically irrelevant with the deprecation of
Panel
, since there are no more ax_e_s (plural), only one non-concatenation ax_i_s.Finally, with
reindex
andreindex_like
, it is redundant as well:Note that the dtype changes due to the intermediate object having
NaN
s in the rows, but this will be fixed by #21160 anyway. Only question is if performance would be much worse, if concatenating huge Series/DFs before selecting small index-subset.The text was updated successfully, but these errors were encountered: