Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

asvs not getting linted #18545

Closed
jbrockmendel opened this issue Nov 28, 2017 · 1 comment
Closed

asvs not getting linted #18545

jbrockmendel opened this issue Nov 28, 2017 · 1 comment
Labels
Benchmark Performance (ASV) benchmarks Code Style Code style, linting, code_checks

Comments

@jbrockmendel
Copy link
Member 

$ flake8 asv_bench/benchmarks/timestamp.py
asv_bench/benchmarks/timestamp.py:1:1: F403 'from .pandas_vb_common import *' used; unable to detect undefined names
asv_bench/benchmarks/timestamp.py:1:1: F401 '.pandas_vb_common.*' imported but unused
asv_bench/benchmarks/timestamp.py:2:1: F401 'pandas.to_timedelta' imported but unused
@jreback jreback added Benchmark Performance (ASV) benchmarks Code Style Code style, linting, code_checks Difficulty Novice labels Nov 29, 2017
@jreback jreback added this to the Next Major Release milestone Nov 29, 2017
@jbrockmendel
Copy link
Member Author

Closed by #18647

@mroeschke mroeschke mentioned this issue Jan 5, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Benchmark Performance (ASV) benchmarks Code Style Code style, linting, code_checks
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jreback @jbrockmendel